Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(832)

Unified Diff: third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js

Issue 2571713005: DevTools: untruncate links on console export (Closed)
Patch Set: rebase Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js
diff --git a/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js b/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js
index efa41a4eacf2aec5d74665e6d3716e402b893bd9..368bce0f601c397bd11c32bc910e31eaa0b388a2 100644
--- a/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js
+++ b/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js
@@ -292,13 +292,17 @@ Console.ConsoleViewMessage = class {
anchorElement = this._linkifyLocation(consoleMessage.url, consoleMessage.line, consoleMessage.column);
}
} else if (consoleMessage.url) {
- anchorElement = Components.Linkifier.linkifyURL(consoleMessage.url, undefined, 'console-message-url');
+ anchorElement = Components.Linkifier.linkifyURL(consoleMessage.url, undefined);
}
// Append a space to prevent the anchor text from being glued to the console message when the user selects and copies the console messages.
- if (anchorElement)
- anchorElement.appendChild(createTextNode(' '));
- return anchorElement;
+ if (anchorElement) {
+ var anchorWrapperElement = createElementWithClass('span', 'console-message-anchor');
+ anchorWrapperElement.appendChild(anchorElement);
+ anchorWrapperElement.createTextChild(' ');
+ return anchorWrapperElement;
+ }
+ return null;
}
/**
@@ -359,7 +363,7 @@ Console.ConsoleViewMessage = class {
var target = this._target();
if (!target)
return null;
- return this._linkifier.linkifyScriptLocation(target, null, url, lineNumber, columnNumber, 'console-message-url');
+ return this._linkifier.linkifyScriptLocation(target, null, url, lineNumber, columnNumber);
}
/**
@@ -370,7 +374,7 @@ Console.ConsoleViewMessage = class {
var target = this._target();
if (!target)
return null;
- return this._linkifier.linkifyStackTraceTopFrame(target, stackTrace, 'console-message-url');
+ return this._linkifier.linkifyStackTraceTopFrame(target, stackTrace);
}
/**
@@ -384,8 +388,7 @@ Console.ConsoleViewMessage = class {
var target = this._target();
if (!target)
return null;
- return this._linkifier.linkifyScriptLocation(
- target, scriptId, url, lineNumber, columnNumber, 'console-message-url');
+ return this._linkifier.linkifyScriptLocation(target, scriptId, url, lineNumber, columnNumber);
}
/**
@@ -1018,6 +1021,22 @@ Console.ConsoleViewMessage = class {
}
/**
+ * @return {string}
+ */
+ toExportString() {
+ var lines = [];
+ var nodes = this.contentElement().childTextNodes();
+ var messageContent = '';
+ for (var i = 0; i < nodes.length; ++i) {
+ var originalLinkText = Components.Linkifier.originalLinkText(nodes[i].parentElement);
+ messageContent += typeof originalLinkText === 'string' ? originalLinkText : nodes[i].textContent;
+ }
+ for (var i = 0; i < this.repeatCount(); ++i)
+ lines.push(messageContent);
+ return lines.join('\n');
+ }
+
+ /**
* @param {?RegExp} regex
*/
setSearchRegex(regex) {

Powered by Google App Engine
This is Rietveld 408576698