Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 2571713004: Fuchsia: Allows building the full SDK for host and target. (Closed)

Created:
4 years ago by zra
Modified:
4 years ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fuchsia: Allows building the full SDK for host and target. R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/7f55ad8b867577b0e05a9054e5fbcf397bac8cd3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+209 lines, -188 lines) Patch
M BUILD.gn View 3 chunks +15 lines, -0 lines 0 comments Download
M runtime/bin/BUILD.gn View 2 chunks +36 lines, -38 lines 0 comments Download
M runtime/vm/BUILD.gn View 1 chunk +132 lines, -134 lines 0 comments Download
M tools/create_timestamp_file.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/patch_sdk.py View 2 chunks +9 lines, -2 lines 0 comments Download
M utils/application_snapshot.gni View 1 chunk +1 line, -1 line 0 comments Download
M utils/compiler/BUILD.gn View 4 chunks +10 lines, -9 lines 0 comments Download
M utils/dartanalyzer/BUILD.gn View 2 chunks +2 lines, -3 lines 0 comments Download
M utils/pub/BUILD.gn View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
zra
4 years ago (2016-12-13 18:45:38 UTC) #2
rmacnak
lgtm
4 years ago (2016-12-13 20:46:29 UTC) #3
zra
4 years ago (2016-12-13 21:02:56 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7f55ad8b867577b0e05a9054e5fbcf397bac8cd3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698