Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(708)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/CSSMetadata.js

Issue 2571713002: DevTools: [SSP] do not autocomplete SVG properties for non-svg nodes (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/sdk/CSSMetadata.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/CSSMetadata.js b/third_party/WebKit/Source/devtools/front_end/sdk/CSSMetadata.js
index c078efef7be15f9598f433d89ea6c185ae9fa48b..8add4b5bdbd628080367f4ef647395046326ca5c 100644
--- a/third_party/WebKit/Source/devtools/front_end/sdk/CSSMetadata.js
+++ b/third_party/WebKit/Source/devtools/front_end/sdk/CSSMetadata.js
@@ -35,7 +35,7 @@
*/
SDK.CSSMetadata = class {
/**
- * @param {!Array.<!{name: string, longhands: !Array.<string>}>} properties
+ * @param {!Array.<!{name: string, longhands: !Array.<string>, inherited: boolean, svg: boolean}>} properties
*/
constructor(properties) {
this._values = /** !Array.<string> */ ([]);
@@ -45,6 +45,8 @@ SDK.CSSMetadata = class {
this._shorthands = new Map();
/** @type {!Set<string>} */
this._inherited = new Set();
+ /** @type {!Set<string>} */
+ this._svgProperties = new Set();
for (var i = 0; i < properties.length; ++i) {
var property = properties[i];
var propertyName = property.name;
@@ -54,6 +56,8 @@ SDK.CSSMetadata = class {
if (property.inherited)
this._inherited.add(propertyName);
+ if (property.svg)
+ this._svgProperties.add(propertyName);
var longhands = properties[i].longhands;
if (longhands) {
@@ -81,6 +85,15 @@ SDK.CSSMetadata = class {
}
/**
+ * @param {string} name
+ * @return {boolean}
+ */
+ isSVGProperty(name) {
+ name = name.toLowerCase();
+ return this._svgProperties.has(name);
+ }
+
+ /**
* @param {string} shorthand
* @return {?Array.<string>}
*/

Powered by Google App Engine
This is Rietveld 408576698