Convert Register Protocol Handler dialog for Harmony/Material Design

chrome/browser/ui/views/chrome_views_delegate.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/chrome_views_delegate.h"
 
 #include <memory>
 
 #include "base/location.h"
 #include "base/logging.h"
@@ skipping 530 matching lines @@
     return gfx::Insets(HarmonyLayoutDelegate::kHarmonyLayoutUnit);
   return ViewsDelegate::GetDialogButtonInsets();
 }
 
 int ChromeViewsDelegate::GetDialogRelatedButtonHorizontalSpacing() {
   if (ui::MaterialDesignController::IsSecondaryUiMaterial())
     return HarmonyLayoutDelegate::kHarmonyLayoutUnit / 2;
   return ViewsDelegate::GetDialogRelatedButtonHorizontalSpacing();
 }
 
+int ChromeViewsDelegate::GetDialogRelatedControlVerticalSpacing() {
+  if (ui::MaterialDesignController::IsSecondaryUiMaterial())
+    return HarmonyLayoutDelegate::kHarmonyLayoutUnit / 2;
+  return ViewsDelegate::GetDialogRelatedControlVerticalSpacing();
+}
+
 gfx::Insets ChromeViewsDelegate::GetDialogFrameViewInsets() {
   if (ui::MaterialDesignController::IsSecondaryUiMaterial()) {
     // Titles are inset at the top and sides, but not at the bottom.
     return gfx::Insets(HarmonyLayoutDelegate::kHarmonyLayoutUnit,
                        HarmonyLayoutDelegate::kHarmonyLayoutUnit, 0,
                        HarmonyLayoutDelegate::kHarmonyLayoutUnit);
   }
   return ViewsDelegate::GetDialogFrameViewInsets();
 }
 
+gfx::Insets ChromeViewsDelegate::GetBubbleDialogMargins() {
+  if (ui::MaterialDesignController::IsSecondaryUiMaterial()) {
+    return gfx::Insets(HarmonyLayoutDelegate::kHarmonyLayoutUnit,
+                       HarmonyLayoutDelegate::kHarmonyLayoutUnit,
+                       HarmonyLayoutDelegate::kHarmonyLayoutUnit,
+                       HarmonyLayoutDelegate::kHarmonyLayoutUnit);
+  }
+  return ViewsDelegate::GetDialogFrameViewInsets();

[sky, 2017/01/05 23:26:40]

Is it intentional that you aren't calling GetBubbleDialogMargins?

[kylix_rd, 2017/01/06 14:36:50]

Oops.

+}
+
 #if !defined(USE_ASH)
 views::Widget::InitParams::WindowOpacity
 ChromeViewsDelegate::GetOpacityForInitParams(
     const views::Widget::InitParams& params) {
   return views::Widget::InitParams::OPAQUE_WINDOW;
 }
 #endif