Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 2571603004: Add debugging information to raw_secure_server_socket_test. (Closed)

Created:
4 years ago by floitsch
Modified:
4 years ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -0 lines) Patch
M tests/standalone/io/raw_secure_server_socket_test.dart View 12 chunks +26 lines, -0 lines 2 comments Download

Messages

Total messages: 8 (2 generated)
floitsch
4 years ago (2016-12-13 14:04:03 UTC) #2
Florian Schneider
https://codereview.chromium.org/2571603004/diff/1/tests/standalone/io/raw_secure_server_socket_test.dart File tests/standalone/io/raw_secure_server_socket_test.dart (right): https://codereview.chromium.org/2571603004/diff/1/tests/standalone/io/raw_secure_server_socket_test.dart#newcode599 tests/standalone/io/raw_secure_server_socket_test.dart:599: runTests() { Would it make sense to split this ...
4 years ago (2016-12-13 18:27:20 UTC) #3
floitsch
https://codereview.chromium.org/2571603004/diff/1/tests/standalone/io/raw_secure_server_socket_test.dart File tests/standalone/io/raw_secure_server_socket_test.dart (right): https://codereview.chromium.org/2571603004/diff/1/tests/standalone/io/raw_secure_server_socket_test.dart#newcode599 tests/standalone/io/raw_secure_server_socket_test.dart:599: runTests() { On 2016/12/13 18:27:20, Florian Schneider wrote: > ...
4 years ago (2016-12-13 19:21:48 UTC) #4
Florian Schneider
I see. I didn't know that limitation of multi-tests. Lgtm.
4 years ago (2016-12-13 19:26:19 UTC) #5
kustermann
lgtm
4 years ago (2016-12-13 19:39:38 UTC) #6
floitsch
4 years ago (2016-12-13 20:29:30 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f1ae158a2a49feae70749f8cee44fa3a6255a3cd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698