Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2571593002: Support for overlay only files in Analysis Server with the new driver. (Closed)

Created:
4 years ago by scheglov
Modified:
4 years ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Support for overlay only files in Analysis Server with the new driver. Do we need this at all? R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/c4ed99acc97bba7e8117877e010b67241347c334

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -7 lines) Patch
M pkg/analysis_server/lib/src/analysis_server.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/context_manager.dart View 2 chunks +16 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/single_context_manager.dart View 1 chunk +5 lines, -0 lines 2 comments Download
M pkg/analysis_server/test/integration/completion/get_suggestions_test.dart View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
scheglov
4 years ago (2016-12-12 20:55:24 UTC) #1
Brian Wilkerson
I think that DartPad uses overlay-only files, so yes, I think we need it. lgtm
4 years ago (2016-12-12 21:02:21 UTC) #2
Paul Berry
https://codereview.chromium.org/2571593002/diff/1/pkg/analysis_server/lib/src/single_context_manager.dart File pkg/analysis_server/lib/src/single_context_manager.dart (right): https://codereview.chromium.org/2571593002/diff/1/pkg/analysis_server/lib/src/single_context_manager.dart#newcode151 pkg/analysis_server/lib/src/single_context_manager.dart:151: return null; Would it be better to throw UnimplementedError ...
4 years ago (2016-12-12 21:11:37 UTC) #3
scheglov
https://codereview.chromium.org/2571593002/diff/1/pkg/analysis_server/lib/src/single_context_manager.dart File pkg/analysis_server/lib/src/single_context_manager.dart (right): https://codereview.chromium.org/2571593002/diff/1/pkg/analysis_server/lib/src/single_context_manager.dart#newcode151 pkg/analysis_server/lib/src/single_context_manager.dart:151: return null; On 2016/12/12 21:11:37, Paul Berry wrote: > ...
4 years ago (2016-12-12 21:13:08 UTC) #4
Paul Berry
On 2016/12/12 21:13:08, scheglov wrote: > https://codereview.chromium.org/2571593002/diff/1/pkg/analysis_server/lib/src/single_context_manager.dart > File pkg/analysis_server/lib/src/single_context_manager.dart (right): > > https://codereview.chromium.org/2571593002/diff/1/pkg/analysis_server/lib/src/single_context_manager.dart#newcode151 > ...
4 years ago (2016-12-12 21:13:54 UTC) #5
scheglov
4 years ago (2016-12-12 21:16:11 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
c4ed99acc97bba7e8117877e010b67241347c334 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698