Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1472)

Unified Diff: content/renderer/render_view_browsertest.cc

Issue 2571583008: Support tracking focused element for OOPIFs. (Closed)
Patch Set: Do not call ScrollFocusedEditableNodeIntoRect for OOPIFs. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_view_browsertest.cc
diff --git a/content/renderer/render_view_browsertest.cc b/content/renderer/render_view_browsertest.cc
index 1c7be7d34abec88474a552c29273515c4cf82532..1684b10ce667106b2f079fab33611b87feb44e56 100644
--- a/content/renderer/render_view_browsertest.cc
+++ b/content/renderer/render_view_browsertest.cc
@@ -1898,27 +1898,27 @@ TEST_F(RenderViewImplTest, FocusElementCallsFocusedNodeChanged) {
ExecuteJavaScriptForTests("document.getElementById('test1').focus();");
const IPC::Message* msg1 = render_thread_->sink().GetFirstMessageMatching(
- ViewHostMsg_FocusedNodeChanged::ID);
+ FrameHostMsg_FocusedNodeChanged::ID);
EXPECT_TRUE(msg1);
- ViewHostMsg_FocusedNodeChanged::Param params;
- ViewHostMsg_FocusedNodeChanged::Read(msg1, &params);
+ FrameHostMsg_FocusedNodeChanged::Param params;
+ FrameHostMsg_FocusedNodeChanged::Read(msg1, &params);
EXPECT_TRUE(std::get<0>(params));
render_thread_->sink().ClearMessages();
ExecuteJavaScriptForTests("document.getElementById('test2').focus();");
const IPC::Message* msg2 = render_thread_->sink().GetFirstMessageMatching(
- ViewHostMsg_FocusedNodeChanged::ID);
+ FrameHostMsg_FocusedNodeChanged::ID);
EXPECT_TRUE(msg2);
- ViewHostMsg_FocusedNodeChanged::Read(msg2, &params);
+ FrameHostMsg_FocusedNodeChanged::Read(msg2, &params);
EXPECT_TRUE(std::get<0>(params));
render_thread_->sink().ClearMessages();
view()->webview()->clearFocusedElement();
const IPC::Message* msg3 = render_thread_->sink().GetFirstMessageMatching(
- ViewHostMsg_FocusedNodeChanged::ID);
+ FrameHostMsg_FocusedNodeChanged::ID);
EXPECT_TRUE(msg3);
- ViewHostMsg_FocusedNodeChanged::Read(msg3, &params);
+ FrameHostMsg_FocusedNodeChanged::Read(msg3, &params);
EXPECT_FALSE(std::get<0>(params));
render_thread_->sink().ClearMessages();
}

Powered by Google App Engine
This is Rietveld 408576698