Support tracking focused element for OOPIFs.

content/browser/renderer_host/render_view_host_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/renderer_host/render_view_host_impl.h"
 
 #include <set>
 #include <string>
 #include <utility>
 #include <vector>
@@ skipping 20 matching lines @@
 #include "components/variations/variations_associated_data.h"
 #include "content/browser/bad_message.h"
 #include "content/browser/child_process_security_policy_impl.h"
 #include "content/browser/dom_storage/session_storage_namespace_impl.h"
 #include "content/browser/frame_host/frame_tree.h"
 #include "content/browser/gpu/compositor_util.h"
 #include "content/browser/gpu/gpu_data_manager_impl.h"
 #include "content/browser/gpu/gpu_process_host.h"
 #include "content/browser/host_zoom_map_impl.h"
 #include "content/browser/loader/resource_dispatcher_host_impl.h"
-#include "content/browser/renderer_host/dip_util.h"
 #include "content/browser/renderer_host/render_process_host_impl.h"
 #include "content/browser/renderer_host/render_view_host_delegate.h"
 #include "content/browser/renderer_host/render_view_host_delegate_view.h"
 #include "content/browser/renderer_host/render_widget_host_delegate.h"
 #include "content/browser/renderer_host/render_widget_host_view_base.h"
 #include "content/common/browser_plugin/browser_plugin_messages.h"
 #include "content/common/content_switches_internal.h"
 #include "content/common/frame_messages.h"
 #include "content/common/input_messages.h"
 #include "content/common/inter_process_time_ticks_converter.h"
 #include "content/common/render_message_filter.mojom.h"
 #include "content/common/renderer.mojom.h"
 #include "content/common/site_isolation_policy.h"
 #include "content/common/speech_recognition_messages.h"
 #include "content/common/swapped_out_messages.h"
 #include "content/common/view_messages.h"
 #include "content/public/browser/ax_event_notification_details.h"
 #include "content/public/browser/browser_accessibility_state.h"
 #include "content/public/browser/browser_context.h"
 #include "content/public/browser/browser_message_filter.h"
 #include "content/public/browser/content_browser_client.h"
-#include "content/public/browser/focused_node_details.h"
 #include "content/public/browser/native_web_keyboard_event.h"
 #include "content/public/browser/notification_details.h"
 #include "content/public/browser/notification_service.h"
 #include "content/public/browser/notification_types.h"
 #include "content/public/browser/render_frame_host.h"
 #include "content/public/browser/render_widget_host_iterator.h"
 #include "content/public/browser/storage_partition.h"
 #include "content/public/browser/user_metrics.h"
 #include "content/public/common/bindings_policy.h"
 #include "content/public/common/content_constants.h"
@@ skipping 128 matching lines @@
       frames_ref_count_(0),
       delegate_(delegate),
       instance_(static_cast<SiteInstanceImpl*>(instance)),
       enabled_bindings_(0),
       is_active_(!swapped_out),
       is_swapped_out_(swapped_out),
       main_frame_routing_id_(main_frame_routing_id),
       is_waiting_for_close_ack_(false),
       sudden_termination_allowed_(false),
       render_view_termination_status_(base::TERMINATION_STATUS_STILL_RUNNING),
-      is_focused_element_editable_(false),
       updating_web_preferences_(false),
       render_view_ready_on_process_launch_(false),
       weak_factory_(this) {
   DCHECK(instance_.get());
   CHECK(delegate_);  // http://crbug.com/82827
 
   GetWidget()->set_owner_delegate(this);
 
   GetProcess()->AddObserver(this);
 
@@ skipping 545 matching lines @@
     IPC_MESSAGE_HANDLER(ViewHostMsg_UpdateTargetURL, OnUpdateTargetURL)
     IPC_MESSAGE_HANDLER(ViewHostMsg_Close, OnClose)
     IPC_MESSAGE_HANDLER(ViewHostMsg_RequestMove, OnRequestMove)
     IPC_MESSAGE_HANDLER(ViewHostMsg_DocumentAvailableInMainFrame,
                         OnDocumentAvailableInMainFrame)
     IPC_MESSAGE_HANDLER(ViewHostMsg_DidContentsPreferredSizeChange,
                         OnDidContentsPreferredSizeChange)
     IPC_MESSAGE_HANDLER(ViewHostMsg_RouteCloseEvent,
                         OnRouteCloseEvent)
     IPC_MESSAGE_HANDLER(ViewHostMsg_TakeFocus, OnTakeFocus)
-    IPC_MESSAGE_HANDLER(ViewHostMsg_FocusedNodeChanged, OnFocusedNodeChanged)
     IPC_MESSAGE_HANDLER(ViewHostMsg_ClosePage_ACK, OnClosePageACK)
     IPC_MESSAGE_HANDLER(ViewHostMsg_DidZoomURL, OnDidZoomURL)
     IPC_MESSAGE_HANDLER(ViewHostMsg_Focus, OnFocus)
-    IPC_MESSAGE_HANDLER(ViewHostMsg_FocusedNodeTouched, OnFocusedNodeTouched)
     IPC_MESSAGE_UNHANDLED(handled = false)
   IPC_END_MESSAGE_MAP()
 
   return handled;
 }
 
 void RenderViewHostImpl::RenderWidgetDidInit() {
   PostRenderViewReady();
 }
 
@@ skipping 121 matching lines @@
   // Have the delegate route this to the active RenderViewHost.
   delegate_->RouteCloseEvent(this);
 }
 
 void RenderViewHostImpl::OnTakeFocus(bool reverse) {
   RenderViewHostDelegateView* view = delegate_->GetDelegateView();
   if (view)
     view->TakeFocus(reverse);
 }
 
-void RenderViewHostImpl::OnFocusedNodeChanged(
-    bool is_editable_node,
-    const gfx::Rect& node_bounds_in_viewport) {
-  is_focused_element_editable_ = is_editable_node;
-
-  // None of the rest makes sense without a view.
-  if (!GetWidget()->GetView())
-    return;
-
-  // Convert node_bounds to screen coordinates.
-  gfx::Rect view_bounds_in_screen = GetWidget()->GetView()->GetViewBounds();
-  gfx::Point origin = node_bounds_in_viewport.origin();
-  origin.Offset(view_bounds_in_screen.x(), view_bounds_in_screen.y());
-  gfx::Rect node_bounds_in_screen(origin.x(), origin.y(),
-                                  node_bounds_in_viewport.width(),
-                                  node_bounds_in_viewport.height());
-
-  GetWidget()->GetView()->FocusedNodeChanged(
-      is_editable_node, node_bounds_in_screen);
-
-  FocusedNodeDetails details = {is_editable_node, node_bounds_in_screen};
-  NotificationService::current()->Notify(NOTIFICATION_FOCUS_CHANGED_IN_PAGE,
-                                         Source<RenderViewHost>(this),
-                                         Details<FocusedNodeDetails>(&details));
-}
-
 void RenderViewHostImpl::OnClosePageACK() {
   GetWidget()->decrement_in_flight_event_count();
   ClosePageIgnoringUnloadEvents();
 }
 
 void RenderViewHostImpl::OnFocus() {
   // Note: We allow focus and blur from swapped out RenderViewHosts, even when
   // the active RenderViewHost is in a different BrowsingInstance (e.g., WebUI).
   delegate_->Activate();
 }
@@ skipping 32 matching lines @@
   // This is defensive code to avoid infinite loops due to code run inside
   // UpdateWebkitPreferences() accidentally updating more preferences and thus
   // calling back into this code. See crbug.com/398751 for one past example.
   if (updating_web_preferences_)
     return;
   updating_web_preferences_ = true;
   UpdateWebkitPreferences(ComputeWebkitPrefs());
   updating_web_preferences_ = false;
 }
 
 void RenderViewHostImpl::ClearFocusedElement() {

[ncarter (slow), 2016/12/16 19:17:21]

Should we consider just moving this method to be part of WebContents' public
interface? Seems like there's just one call, and it would be a trivial change to
make, and less code overall.

[EhsanK, 2016/12/20 16:39:10]

Yes absolutely. I didn't do this for two reasons:
1- Wasn't sure if this concept is a WebContents thing
2- Wasn't sure if I should modify public API and the corresponding changes in
tests and other files in this patch (which might merge to M56).

But I think the logic should be in WebContentsImpl in general unless we want to
use GetFocusedFrame() inside RenderViewHost.

-  is_focused_element_editable_ = false;
-  Send(new ViewMsg_ClearFocusedElement(GetRoutingID()));
+  if (delegate_)
+    delegate_->ClearFocusedElement();
 }
 
 bool RenderViewHostImpl::IsFocusedElementEditable() {

[ncarter (slow), 2016/12/16 19:17:21]

Same question here. There are a couple more callers, but they're all of the form
web_contents()->GetRVH()->IsFocusedElementEditable.

[EhsanK, 2016/12/20 16:39:10]

+1 to moving to WebContentsImpl. Maybe I leave a TODO here?

-  return is_focused_element_editable_;
+  return delegate_ && delegate_->IsFocusedElementEditable();
 }
 
 void RenderViewHostImpl::Zoom(PageZoom zoom) {
   Send(new ViewMsg_Zoom(GetRoutingID(), zoom));
 }
 
 void RenderViewHostImpl::DisableScrollbarsForThreshold(const gfx::Size& size) {
   Send(new ViewMsg_DisableScrollbarsForSmallWindows(GetRoutingID(), size));
 }
 
@@ skipping 32 matching lines @@
                                       const GURL& url) {
   HostZoomMapImpl* host_zoom_map =
       static_cast<HostZoomMapImpl*>(HostZoomMap::Get(GetSiteInstance()));
 
   host_zoom_map->SetZoomLevelForView(GetProcess()->GetID(),
                                      GetRoutingID(),
                                      zoom_level,
                                      net::GetHostOrSpecFromURL(url));
 }
 
-void RenderViewHostImpl::OnFocusedNodeTouched(bool editable) {
-#if defined(OS_WIN)
-  // We use the cursor position to determine where the touch occurred.
-  // TODO(ananta)
-  // Pass this information from blink.
-  // In site isolation mode, we may not have a RenderViewHostImpl instance
-  // which means that displaying the OSK is not going to work. We should
-  // probably move this to RenderWidgetHostImpl and call the view from there.
-  // https://bugs.chromium.org/p/chromium/issues/detail?id=613326
-  POINT cursor_pos = {};
-  ::GetCursorPos(&cursor_pos);
-  float scale = GetScaleFactorForView(GetWidget()->GetView());
-  gfx::Point location_dips_screen =
-      gfx::ConvertPointToDIP(scale, gfx::Point(cursor_pos));
-  if (GetWidget()->GetView())
-    GetWidget()->GetView()->FocusedNodeTouched(location_dips_screen, editable);
-#endif
-}
-
 void RenderViewHostImpl::SelectWordAroundCaret() {
   Send(new ViewMsg_SelectWordAroundCaret(GetRoutingID()));
 }
 
 void RenderViewHostImpl::PostRenderViewReady() {
   if (GetProcess()->IsReady()) {
     BrowserThread::PostTask(
         BrowserThread::UI,
         FROM_HERE,
         base::Bind(&RenderViewHostImpl::RenderViewReady,
                    weak_factory_.GetWeakPtr()));
   } else {
     render_view_ready_on_process_launch_ = true;
   }
 }
 
 void RenderViewHostImpl::RenderViewReady() {
   delegate_->RenderViewReady(this);
 }
 
 }  // namespace content