move extractDefinedVariables from analyzer cli to analyzer

move extractDefinedVariables from analyzer cli to analyzer

R=brianwilkerson@google.com

Committed: https://github.com/dart-lang/sdk/commit/1417eec66e34146133c86b616aa60431ccf8095d

[danrubel, 2016-12-14 17:07:00]

danrubel@google.com changed reviewers:
+ brianwilkerson@google.com

[Brian Wilkerson, 2016-12-14 17:47:35]

https://codereview.chromium.org/2571583007/diff/1/pkg/analyzer/lib/src/comman...
File pkg/analyzer/lib/src/command_line/arguments.dart (right):

https://codereview.chromium.org/2571583007/diff/1/pkg/analyzer/lib/src/comman...
pkg/analyzer/lib/src/command_line/arguments.dart:173: List<String>
extractDefinedVariables(
This is already being done as part of createContextBuilderOptions. Given that we
want to move everyone to using ContextBuilder, we could just build the options,
and extract the declared variables for now knowing that this gets us closer to
the longer term goal.

[danrubel, 2016-12-14 18:06:57]

https://codereview.chromium.org/2571583007/diff/1/pkg/analyzer/lib/src/comman...
File pkg/analyzer/lib/src/command_line/arguments.dart (right):

https://codereview.chromium.org/2571583007/diff/1/pkg/analyzer/lib/src/comman...
pkg/analyzer/lib/src/command_line/arguments.dart:173: List<String>
extractDefinedVariables(
On 2016/12/14 17:47:35, Brian Wilkerson wrote:
> This is already being done as part of createContextBuilderOptions. Given that
we
> want to move everyone to using ContextBuilder, we could just build the
options,
> and extract the declared variables for now knowing that this gets us closer to
> the longer term goal.

That makes sense as a long term goal, but I'd like to take it in smaller steps.
I tried to be more ambitious last week and didn't make any progress. I found
that detangling and normalizing Analyzer CLI and DDC code to be more involved
than I thought. This week I'm taking it in smaller steps and making good
progress. Ok if I check this in as a step towards what you describe?

[Brian Wilkerson, 2016-12-14 18:11:26]

I suppose, but it would be good to add a TODO comment to make it clear that this
is a temporary step. In which case, lgtm.

[danrubel, 2016-12-14 18:14:29]

On 2016/12/14 18:11:26, Brian Wilkerson wrote:
> I suppose, but it would be good to add a TODO comment to make it clear that
this
> is a temporary step. In which case, lgtm.

Good point. Done.

[danrubel, 2016-12-14 18:22:46]

Description was changed from

==========
move extractDefinedVariables from analyzer cli to analyzer
==========

to

==========
move extractDefinedVariables from analyzer cli to analyzer

R=brianwilkerson@google.com

Committed:
https://github.com/dart-lang/sdk/commit/1417eec66e34146133c86b616aa60431ccf8095d
==========

[danrubel, 2016-12-14 18:22:47]

Committed patchset #2 (id:20001) manually as
1417eec66e34146133c86b616aa60431ccf8095d (presubmit successful).