Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Unified Diff: tools/patch_sdk.dart

Issue 2571563005: Turn the VM's dart:typed_data into a patch (Closed)
Patch Set: Fix interface/implementation type mismatch Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/vm.gypi ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/patch_sdk.dart
diff --git a/tools/patch_sdk.dart b/tools/patch_sdk.dart
index 5a76ff5f5d368504b90eab6e991d5bf89294a893..e9980eab858fc52d212d1ab8e4b1b2710547f4fc 100644
--- a/tools/patch_sdk.dart
+++ b/tools/patch_sdk.dart
@@ -110,14 +110,7 @@ void main(List<String> argv) {
var libraryOut = path.join(sdkLibIn, library.path);
var libraryIn;
- if (mode == 'vm' && library.path.contains('typed_data.dart')) {
- // dart:typed_data is unlike the other libraries in the SDK. The VM does
- // not apply a patch to the base SDK implementation of the library.
- // Instead, the VM provides a replacement implementation and ignores the
- // sources in the SDK.
- libraryIn =
- path.join(dartDir, 'runtime', 'lib', 'typed_data.dart');
- } else if (mode == 'ddc' && library.path.contains(INTERNAL_PATH)) {
+ if (mode == 'ddc' && library.path.contains(INTERNAL_PATH)) {
libraryIn =
path.join(privateIn, library.path.replaceAll(INTERNAL_PATH, ''));
} else {
« no previous file with comments | « runtime/vm/vm.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698