Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(930)

Unified Diff: src/interpreter/bytecode-array-builder.h

Issue 2571563004: [Turbofan] Implement super calls with spread bytecode in assembly code. (Closed)
Patch Set: Update builtins for new push args modes Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/interpreter/bytecode-array-builder.h
diff --git a/src/interpreter/bytecode-array-builder.h b/src/interpreter/bytecode-array-builder.h
index c2568eb8e6612d18acf9cdc1ecbc8c01c1f5f89d..39c8d9259c5c80806aed3db7b70328433e6099b1 100644
--- a/src/interpreter/bytecode-array-builder.h
+++ b/src/interpreter/bytecode-array-builder.h
@@ -243,10 +243,10 @@ class V8_EXPORT_PRIVATE BytecodeArrayBuilder final
// Call the JS runtime function with |context_index| and arguments |args|.
BytecodeArrayBuilder& CallJSRuntime(int context_index, RegisterList args);
- // Call the constructor in |args[0]| with new_target in |args[1]| and the
- // arguments starting at |args[2]| onwards. The final argument must be a
- // spread.
- BytecodeArrayBuilder& NewWithSpread(RegisterList args);
+ // Call the new operator for use with a spread. The accumulator holds the
+ // |new_target|. The |constructor| is in a register and arguments are in
+ // |args|. The final argument must be a spread.
+ BytecodeArrayBuilder& NewWithSpread(Register constructor, RegisterList args);
rmcilroy 2017/01/16 16:28:02 I realize you didn't change this in this CL, but t
petermarshall 2017/01/18 10:05:32 Done
// Operators (register holds the lhs value, accumulator holds the rhs value).
// Type feedback will be recorded in the |feedback_slot|

Powered by Google App Engine
This is Rietveld 408576698