Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Unified Diff: src/builtins/builtins.h

Issue 2571563004: [Turbofan] Implement super calls with spread bytecode in assembly code. (Closed)
Patch Set: Update builtins for new push args modes Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/builtins/builtins.h
diff --git a/src/builtins/builtins.h b/src/builtins/builtins.h
index dcff15068f83275b86dea74085b89feff6cda0c2..9ccf744bd45e6c28b853633ed39b2c6306f281bf 100644
--- a/src/builtins/builtins.h
+++ b/src/builtins/builtins.h
@@ -85,6 +85,7 @@ namespace internal {
ASM(ConstructProxy) \
/* ES6 section 7.3.13 Construct (F, [argumentsList], [newTarget]) */ \
ASM(Construct) \
+ ASM(ConstructWithSpread) \
ASM(JSConstructStubApi) \
ASM(JSConstructStubGeneric) \
ASM(JSBuiltinsConstructStub) \
@@ -143,6 +144,7 @@ namespace internal {
ASM(InterpreterPushArgsAndConstruct) \
ASM(InterpreterPushArgsAndConstructFunction) \
ASM(InterpreterPushArgsAndConstructArray) \
+ ASM(InterpreterPushArgsAndConstructWithFinalSpread) \
ASM(InterpreterEnterBytecodeAdvance) \
ASM(InterpreterEnterBytecodeDispatch) \
ASM(InterpreterOnStackReplacement) \
@@ -791,6 +793,7 @@ namespace internal {
// Forward declarations.
class ObjectVisitor;
+enum class PushArgsConstructMode : unsigned;
namespace compiler {
class CodeAssemblerState;
}
@@ -835,7 +838,7 @@ class Builtins {
Handle<Code> InterpreterPushArgsAndCall(
TailCallMode tail_call_mode,
CallableType function_type = CallableType::kAny);
- Handle<Code> InterpreterPushArgsAndConstruct(CallableType function_type);
+ Handle<Code> InterpreterPushArgsAndConstruct(PushArgsConstructMode mode);
Handle<Code> NewFunctionContext(ScopeType scope_type);
Handle<Code> NewCloneShallowArray(AllocationSiteMode allocation_mode);
Handle<Code> NewCloneShallowObject(int length);
@@ -893,7 +896,7 @@ class Builtins {
CallableType function_type);
static void Generate_InterpreterPushArgsAndConstructImpl(
- MacroAssembler* masm, CallableType function_type);
+ MacroAssembler* masm, PushArgsConstructMode mode);
enum class MathMaxMinKind { kMax, kMin };
static void Generate_MathMaxMin(MacroAssembler* masm, MathMaxMinKind kind);

Powered by Google App Engine
This is Rietveld 408576698