[Turbofan] Implement super calls with spread bytecode in assembly code.

src/interpreter/interpreter.cc

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/interpreter/interpreter.h"
 
 #include <fstream>
 #include <memory>
 
 #include "src/ast/prettyprinter.h"
@@ skipping 2140 matching lines @@
   Node* native_context = __ LoadNativeContext(context);
   Node* function = __ LoadContextElement(native_context, context_index);
 
   // Call the function.
   Node* result = __ CallJS(function, context, first_arg, args_count,
                            TailCallMode::kDisallow);
   __ SetAccumulator(result);
   __ Dispatch();
 }
 
 // NewWithSpread <first_arg> <arg_count>

[rmcilroy, 2017/01/11 15:24:45]

Please update the comment and description.

 //
 // Call the constructor in |first_arg| with the new.target in |first_arg + 1|
 // for the |arg_count - 2| following arguments. The final argument is always a
 // spread.
 //
 void Interpreter::DoNewWithSpread(InterpreterAssembler* assembler) {
-  Node* first_arg_reg = __ BytecodeOperandReg(0);
+  // Callable ic = CodeFactory::ConstructWithSpread(isolate_);

[rmcilroy, 2017/01/11 15:24:45]

leftover code?

[petermarshall, 2017/01/11 16:50:03]

Yeah not needed, there is a similar line left in Interpreter::DoNew but not as a
commment, which I'll submit another CL to remove, given that it doesn't do
anything.

Updated the comment here too.

+  Node* new_target = __ GetAccumulator();
+  Node* constructor_reg = __ BytecodeOperandReg(0);
+  Node* constructor = __ LoadRegister(constructor_reg);
+  Node* first_arg_reg = __ BytecodeOperandReg(1);
   Node* first_arg = __ RegisterLocation(first_arg_reg);
-  Node* args_count = __ BytecodeOperandCount(1);
+  Node* args_count = __ BytecodeOperandCount(2);
   Node* context = __ GetContext();
-
-  // Call into Runtime function NewWithSpread which does everything.
-  Node* runtime_function = __ Int32Constant(Runtime::kNewWithSpread);
-  Node* result =
-      __ CallRuntimeN(runtime_function, context, first_arg, args_count);
+  Node* result = __ CallConstructWithSpread(constructor, context, new_target,
+                                            first_arg, args_count);
   __ SetAccumulator(result);
   __ Dispatch();
 }
 
 // New <constructor> <first_arg> <arg_count>
 //
 // Call operator new with |constructor| and the first argument in
 // register |first_arg| and |arg_count| arguments in subsequent
 // registers. The new.target is in the accumulator.
 //
@@ skipping 1064 matching lines @@
   __ StoreObjectField(generator, JSGeneratorObject::kContinuationOffset,
       __ SmiTag(new_state));
   __ SetAccumulator(old_state);
 
   __ Dispatch();
 }
 
 }  // namespace interpreter
 }  // namespace internal
 }  // namespace v8