content/shell/browser/shell_devtools_frontend.cc - Issue 257153003: We have a problem in the process on destroying WebContentsImpl because

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/browser/shell_devtools_frontend.cc

Issue 257153003: We have a problem in the process on destroying WebContentsImpl because (Closed) Base URL: https://git.chromium.org/chromium/src.git@master

Patch Set: Removed what was added in https://codereview.chromium.org/239393009 Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/public/browser/web_contents_observer.h ('K') | « content/shell/browser/shell_devtools_frontend.h ('k') | content/shell/browser/webkit_test_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/shell/browser/shell_devtools_frontend.cc

diff --git a/content/shell/browser/shell_devtools_frontend.cc b/content/shell/browser/shell_devtools_frontend.cc

index 6d0e1f0102f1acd39634f2d6856c75d68fd5cdfe..5944c9b68f2868d2dd0cfc13e83291922ca88f2c 100644

--- a/content/shell/browser/shell_devtools_frontend.cc

+++ b/content/shell/browser/shell_devtools_frontend.cc

@@ -126,7 +126,7 @@ void ShellDevToolsFrontend::DocumentOnLoadCompletedInMainFrame(int32 page_id) {

base::ASCIIToUTF16("InspectorFrontendAPI.setUseSoftMenu(true);"));

}

-void ShellDevToolsFrontend::WebContentsDestroyed(WebContents* web_contents) {

+void ShellDevToolsFrontend::WebContentsDestroyed() {

DevToolsManager::GetInstance()->ClientHostClosing(frontend_host_.get());

delete this;

}