content/browser/media/capture/web_contents_video_capture_device.cc - Issue 257153003: We have a problem in the process on destroying WebContentsImpl because

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/media/capture/web_contents_video_capture_device.cc

Issue 257153003: We have a problem in the process on destroying WebContentsImpl because (Closed) Base URL: https://git.chromium.org/chromium/src.git@master

Patch Set: Removed what was added in https://codereview.chromium.org/239393009 Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/passwords/manage_passwords_bubble_model.h ('K') | « content/browser/media/capture/web_contents_tracker.cc ('k') | content/browser/web_contents/web_contents_impl.cc » ('j') | content/public/browser/web_contents_observer.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/media/capture/web_contents_video_capture_device.cc

diff --git a/content/browser/media/capture/web_contents_video_capture_device.cc b/content/browser/media/capture/web_contents_video_capture_device.cc

index fba8e1bd23a905676b15ce12ccabdb859a51069e..fc2a1f1ac408f7dbcd02132bc880342732ce4829 100644

--- a/content/browser/media/capture/web_contents_video_capture_device.cc

+++ b/content/browser/media/capture/web_contents_video_capture_device.cc

@@ -269,7 +269,7 @@ class WebContentsCaptureMachine

RenewFrameSubscription();

}

- virtual void WebContentsDestroyed(WebContents* web_contents) OVERRIDE;

+ virtual void WebContentsDestroyed() OVERRIDE;

private:

// Starts observing the web contents, returning false if lookup fails.

@@ -702,12 +702,11 @@ bool WebContentsCaptureMachine::StartObservingWebContents() {

return false;

}

-void WebContentsCaptureMachine::WebContentsDestroyed(

- WebContents* web_contents) {

+void WebContentsCaptureMachine::WebContentsDestroyed() {

DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

subscription_.reset();

- web_contents->DecrementCapturerCount();

+ web_contents()->DecrementCapturerCount();

oracle_proxy_->ReportError("WebContentsDestroyed()");

}