content/browser/android/web_contents_observer_android.cc - Issue 257153003: We have a problem in the process on destroying WebContentsImpl because

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/android/web_contents_observer_android.cc

Issue 257153003: We have a problem in the process on destroying WebContentsImpl because (Closed) Base URL: https://git.chromium.org/chromium/src.git@master

Patch Set: Removed what was added in https://codereview.chromium.org/239393009 Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/passwords/manage_passwords_bubble_model.h ('K') | « content/browser/android/web_contents_observer_android.h ('k') | content/browser/browser_plugin/browser_plugin_guest.cc » ('j') | content/public/browser/web_contents_observer.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/android/web_contents_observer_android.cc

diff --git a/content/browser/android/web_contents_observer_android.cc b/content/browser/android/web_contents_observer_android.cc

index 9a0d56ac26f9514f5a64396fb25b92333ee05b15..6fbfab693e93f5f1a791beb94a02c5178ca804ce 100644

--- a/content/browser/android/web_contents_observer_android.cc

+++ b/content/browser/android/web_contents_observer_android.cc

@@ -48,8 +48,7 @@ void WebContentsObserverAndroid::Destroy(JNIEnv* env, jobject obj) {

delete this;

}

-void WebContentsObserverAndroid::WebContentsDestroyed(

- WebContents* web_contents) {

+void WebContentsObserverAndroid::WebContentsDestroyed() {

JNIEnv* env = AttachCurrentThread();

ScopedJavaLocalRef<jobject> obj(weak_java_observer_.get(env));

if (obj.is_null()) {