components/web_modal/web_contents_modal_dialog_manager.cc - Issue 257153003: We have a problem in the process on destroying WebContentsImpl because

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/web_modal/web_contents_modal_dialog_manager.cc

Issue 257153003: We have a problem in the process on destroying WebContentsImpl because (Closed) Base URL: https://git.chromium.org/chromium/src.git@master

Patch Set: Removed what was added in https://codereview.chromium.org/239393009 Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/passwords/manage_passwords_bubble_model.h ('K') | « components/web_modal/web_contents_modal_dialog_manager.h ('k') | content/browser/android/content_settings.h » ('j') | content/public/browser/web_contents_observer.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/web_modal/web_contents_modal_dialog_manager.cc

diff --git a/components/web_modal/web_contents_modal_dialog_manager.cc b/components/web_modal/web_contents_modal_dialog_manager.cc

index a837bcc96fe0008eded33cec79fa0dfc43f4d7a5..7ae8a2dc6e32c40a976920136041b7f57b260bec 100644

--- a/components/web_modal/web_contents_modal_dialog_manager.cc

+++ b/components/web_modal/web_contents_modal_dialog_manager.cc

@@ -187,7 +187,7 @@ void WebContentsModalDialogManager::WasHidden() {

child_dialogs_.front()->manager->Hide();

}

-void WebContentsModalDialogManager::WebContentsDestroyed(WebContents* tab) {

+void WebContentsModalDialogManager::WebContentsDestroyed() {

// First cleanly close all child dialogs.

// TODO(mpcomplete): handle case if MaybeCloseChildWindows() already asked

// some of these to close. CloseAllDialogs is async, so it might get called