chrome/browser/ui/website_settings/permission_bubble_manager.h - Issue 257153003: We have a problem in the process on destroying WebContentsImpl because

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/website_settings/permission_bubble_manager.h

Issue 257153003: We have a problem in the process on destroying WebContentsImpl because (Closed) Base URL: https://git.chromium.org/chromium/src.git@master

Patch Set: Removed what was added in https://codereview.chromium.org/239393009 Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/passwords/manage_passwords_bubble_model.h ('K') | « chrome/browser/ui/views/translate/translate_bubble_view.cc ('k') | chrome/browser/ui/website_settings/permission_bubble_manager.cc » ('j') | content/public/browser/web_contents_observer.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/website_settings/permission_bubble_manager.h

diff --git a/chrome/browser/ui/website_settings/permission_bubble_manager.h b/chrome/browser/ui/website_settings/permission_bubble_manager.h

index bbf8e85fd4296287312056e52b024a085514cd39..c21be9053301696dd4251716f3f172d3bbf7ad0c 100644

--- a/chrome/browser/ui/website_settings/permission_bubble_manager.h

+++ b/chrome/browser/ui/website_settings/permission_bubble_manager.h

@@ -73,8 +73,7 @@ class PermissionBubbleManager

// they will be finalized as if canceled by the user.

virtual void NavigationEntryCommitted(

const content::LoadCommittedDetails& details) OVERRIDE;

- virtual void WebContentsDestroyed(

- content::WebContents* web_contents) OVERRIDE;

+ virtual void WebContentsDestroyed() OVERRIDE;

// PermissionBubbleView::Delegate:

virtual void ToggleAccept(int request_index, bool new_value) OVERRIDE;