chrome/browser/ui/tab_contents/core_tab_helper.cc - Issue 257153003: We have a problem in the process on destroying WebContentsImpl because

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/tab_contents/core_tab_helper.cc

Issue 257153003: We have a problem in the process on destroying WebContentsImpl because (Closed) Base URL: https://git.chromium.org/chromium/src.git@master

Patch Set: Removed what was added in https://codereview.chromium.org/239393009 Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/passwords/manage_passwords_bubble_model.h ('K') | « chrome/browser/ui/tab_contents/core_tab_helper.h ('k') | chrome/browser/ui/tabs/tab_strip_model.cc » ('j') | content/public/browser/web_contents_observer.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/tab_contents/core_tab_helper.cc

diff --git a/chrome/browser/ui/tab_contents/core_tab_helper.cc b/chrome/browser/ui/tab_contents/core_tab_helper.cc

index 99f93b25c36a17041eb697346606b1a00137d501..d30bbaf5043f1695cef28e2642d899bfb7a6087e 100644

--- a/chrome/browser/ui/tab_contents/core_tab_helper.cc

+++ b/chrome/browser/ui/tab_contents/core_tab_helper.cc

@@ -150,7 +150,7 @@ void CoreTabHelper::WasShown() {

web_contents()->GetRenderProcessHost()->GetID());

}

-void CoreTabHelper::WebContentsDestroyed(WebContents* web_contents) {

+void CoreTabHelper::WebContentsDestroyed() {

// OnCloseStarted isn't called in unit tests.

if (!close_start_time_.is_null()) {

bool fast_tab_close_enabled = CommandLine::ForCurrentProcess()->HasSwitch(