chrome/browser/ui/omnibox/omnibox_navigation_observer.cc - Issue 257153003: We have a problem in the process on destroying WebContentsImpl because

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/omnibox/omnibox_navigation_observer.cc

Issue 257153003: We have a problem in the process on destroying WebContentsImpl because (Closed) Base URL: https://git.chromium.org/chromium/src.git@master

Patch Set: Removed what was added in https://codereview.chromium.org/239393009 Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/autofill/autofill_popup_controller_interactive_uitest.cc ('K') | « chrome/browser/ui/omnibox/omnibox_navigation_observer.h ('k') | chrome/browser/ui/panels/panel_host.h » ('j') | chrome/browser/ui/passwords/manage_passwords_bubble_model.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/omnibox/omnibox_navigation_observer.cc

diff --git a/chrome/browser/ui/omnibox/omnibox_navigation_observer.cc b/chrome/browser/ui/omnibox/omnibox_navigation_observer.cc

index 9e5a44aafa0d49d3b9a1031fb355502813d057a8..51a19b79cafeb0e157e92f9d981397cb276b1c76 100644

--- a/chrome/browser/ui/omnibox/omnibox_navigation_observer.cc

+++ b/chrome/browser/ui/omnibox/omnibox_navigation_observer.cc

@@ -108,8 +108,7 @@ void OmniboxNavigationObserver::NavigationEntryCommitted(

OnAllLoadingFinished(); // deletes |this|!

}

-void OmniboxNavigationObserver::WebContentsDestroyed(

- content::WebContents* web_contents) {

+void OmniboxNavigationObserver::WebContentsDestroyed() {

delete this;

}