chrome/browser/printing/background_printing_manager.cc - Issue 257153003: We have a problem in the process on destroying WebContentsImpl because

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/printing/background_printing_manager.cc

Issue 257153003: We have a problem in the process on destroying WebContentsImpl because (Closed) Base URL: https://git.chromium.org/chromium/src.git@master

Patch Set: Removed what was added in https://codereview.chromium.org/239393009 Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/prerender/prerender_manager.cc ('k') | chrome/browser/printing/print_dialog_cloud.cc » ('j') | chrome/browser/ui/autofill/autofill_popup_controller_interactive_uitest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/printing/background_printing_manager.cc

diff --git a/chrome/browser/printing/background_printing_manager.cc b/chrome/browser/printing/background_printing_manager.cc

index 4a29c654a2885641bc9ab1fb520d37f1084258db..1e5c58d661534afa27689138f2d499858bdbdbef 100644

--- a/chrome/browser/printing/background_printing_manager.cc

+++ b/chrome/browser/printing/background_printing_manager.cc

@@ -28,7 +28,7 @@ class BackgroundPrintingManager::Observer

private:

virtual void RenderProcessGone(base::TerminationStatus status) OVERRIDE;

- virtual void WebContentsDestroyed(WebContents* web_contents) OVERRIDE;

+ virtual void WebContentsDestroyed() OVERRIDE;

BackgroundPrintingManager* manager_;

};

@@ -43,9 +43,8 @@ void BackgroundPrintingManager::Observer::RenderProcessGone(

base::TerminationStatus status) {

manager_->DeletePreviewContents(web_contents());

}

-void BackgroundPrintingManager::Observer::WebContentsDestroyed(

- WebContents* web_contents) {

- manager_->DeletePreviewContents(web_contents);

+void BackgroundPrintingManager::Observer::WebContentsDestroyed() {

+ manager_->DeletePreviewContents(web_contents());

}

BackgroundPrintingManager::BackgroundPrintingManager() {