chrome/browser/media_galleries/media_file_system_registry.cc - Issue 257153003: We have a problem in the process on destroying WebContentsImpl because

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media_galleries/media_file_system_registry.cc

Issue 257153003: We have a problem in the process on destroying WebContentsImpl because (Closed) Base URL: https://git.chromium.org/chromium/src.git@master

Patch Set: Removed what was added in https://codereview.chromium.org/239393009 Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/media/media_stream_capture_indicator.cc ('k') | chrome/browser/policy/policy_browsertest.cc » ('j') | chrome/browser/ui/autofill/autofill_popup_controller_interactive_uitest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/media_galleries/media_file_system_registry.cc

diff --git a/chrome/browser/media_galleries/media_file_system_registry.cc b/chrome/browser/media_galleries/media_file_system_registry.cc

index 08cecd1cb07571e8c52e11a20a6d7baa1cd09462..a53ed2be781acc5254baa3028336927691109d4a 100644

--- a/chrome/browser/media_galleries/media_file_system_registry.cc

+++ b/chrome/browser/media_galleries/media_file_system_registry.cc

@@ -85,7 +85,7 @@ class RPHReferenceManager {

private:

// content::WebContentsObserver

- virtual void WebContentsDestroyed(WebContents* web_contents) OVERRIDE;

+ virtual void WebContentsDestroyed() OVERRIDE;

virtual void NavigationEntryCommitted(

const content::LoadCommittedDetails& load_details) OVERRIDE;

@@ -155,9 +155,8 @@ RPHReferenceManager::RPHWebContentsObserver::RPHWebContentsObserver(

manager_(manager) {

}

-void RPHReferenceManager::RPHWebContentsObserver::WebContentsDestroyed(

- WebContents* web_contents) {

- manager_->OnWebContentsDestroyedOrNavigated(web_contents);

+void RPHReferenceManager::RPHWebContentsObserver::WebContentsDestroyed() {

+ manager_->OnWebContentsDestroyedOrNavigated(web_contents());

}

void RPHReferenceManager::RPHWebContentsObserver::NavigationEntryCommitted(