chrome/browser/history/history_tab_helper.cc - Issue 257153003: We have a problem in the process on destroying WebContentsImpl because

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/history/history_tab_helper.cc

Issue 257153003: We have a problem in the process on destroying WebContentsImpl because (Closed) Base URL: https://git.chromium.org/chromium/src.git@master

Patch Set: Removed what was added in https://codereview.chromium.org/239393009 Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/history/history_tab_helper.h ('k') | chrome/browser/infobars/infobar_service.h » ('j') | chrome/browser/ui/autofill/autofill_popup_controller_interactive_uitest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/history/history_tab_helper.cc

diff --git a/chrome/browser/history/history_tab_helper.cc b/chrome/browser/history/history_tab_helper.cc

index 03ccc8157f2f73e4ad75c88d34b47967bfb6f21f..948811b774f7621b03fb041c6f0ad52e2b82db64 100644

--- a/chrome/browser/history/history_tab_helper.cc

+++ b/chrome/browser/history/history_tab_helper.cc

@@ -153,10 +153,9 @@ HistoryService* HistoryTabHelper::GetHistoryService() {

Profile::IMPLICIT_ACCESS);

}

-void HistoryTabHelper::WebContentsDestroyed(WebContents* tab) {

+void HistoryTabHelper::WebContentsDestroyed() {

// We update the history for this URL.

- // The content returned from web_contents() has been destroyed by now.

- // We need to use tab value directly.

+ WebContents* tab = web_contents();

Profile* profile = Profile::FromBrowserContext(tab->GetBrowserContext());

if (profile->IsOffTheRecord())

return;