content/public/test/test_navigation_observer.cc - Issue 257153003: We have a problem in the process on destroying WebContentsImpl because

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/test/test_navigation_observer.cc

Issue 257153003: We have a problem in the process on destroying WebContentsImpl because (Closed) Base URL: https://git.chromium.org/chromium/src.git@master

Patch Set: Rebased onto origin/master again, resolved conflicts Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/public/test/test_navigation_observer.cc

diff --git a/content/public/test/test_navigation_observer.cc b/content/public/test/test_navigation_observer.cc

index cad43a8cb6348ba6ff10cac34cfbff4c3f10d6c0..bfe74f663589ab4719fd6e74a94504f72888fff4 100644

--- a/content/public/test/test_navigation_observer.cc

+++ b/content/public/test/test_navigation_observer.cc

@@ -34,8 +34,8 @@ class TestNavigationObserver::TestWebContentsObserver

parent_->OnDidAttachInterstitialPage(web_contents());

}

- virtual void WebContentsDestroyed(WebContents* web_contents) OVERRIDE {

- parent_->OnWebContentsDestroyed(this, web_contents);

+ virtual void WebContentsDestroyed() OVERRIDE {

+ parent_->OnWebContentsDestroyed(this, web_contents());

}

virtual void DidStartLoading(RenderViewHost* render_view_host) OVERRIDE {

« no previous file with comments | « content/public/test/browser_test_utils.cc ('k') | content/shell/browser/shell.cc » ('j') | no next file with comments »