Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1278)

Unified Diff: content/browser/frame_host/interstitial_page_impl.cc

Issue 257153003: We have a problem in the process on destroying WebContentsImpl because (Closed) Base URL: https://git.chromium.org/chromium/src.git@master
Patch Set: Rebased onto origin/master again, resolved conflicts Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/interstitial_page_impl.cc
diff --git a/content/browser/frame_host/interstitial_page_impl.cc b/content/browser/frame_host/interstitial_page_impl.cc
index 44c5876d33c06d26d8ff43aa91fd2713023427ec..e8f73a4b3be9a2f928e28934b329b37425f0db4f 100644
--- a/content/browser/frame_host/interstitial_page_impl.cc
+++ b/content/browser/frame_host/interstitial_page_impl.cc
@@ -356,18 +356,7 @@ void InterstitialPageImpl::NavigationEntryCommitted(
OnNavigatingAwayOrTabClosing();
}
-void InterstitialPageImpl::WebContentsWillBeDestroyed() {
- OnNavigatingAwayOrTabClosing();
-}
-
-void InterstitialPageImpl::WebContentsDestroyed(WebContents* web_contents) {
- // WebContentsImpl will only call WebContentsWillBeDestroyed for interstitial
- // pages that it knows about, pages that called
- // WebContentsImpl::AttachInterstitialPage. But it's possible to have an
- // interstitial page that never progressed that far. In that case, ensure that
- // this interstitial page is destroyed. (And if it was attached, and
- // OnNavigatingAwayOrTabClosing was called, it's safe to call
- // OnNavigatingAwayOrTabClosing twice.)
+void InterstitialPageImpl::WebContentsDestroyed() {
OnNavigatingAwayOrTabClosing();
}
« no previous file with comments | « content/browser/frame_host/interstitial_page_impl.h ('k') | content/browser/media/capture/web_contents_tracker.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698