chrome/browser/ui/website_settings/permission_bubble_manager.cc - Issue 257153003: We have a problem in the process on destroying WebContentsImpl because

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/website_settings/permission_bubble_manager.cc

Issue 257153003: We have a problem in the process on destroying WebContentsImpl because (Closed) Base URL: https://git.chromium.org/chromium/src.git@master

Patch Set: Rebased onto origin/master again, resolved conflicts Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/website_settings/permission_bubble_manager.h ('k') | chrome/browser/ui/webui/constrained_web_dialog_ui_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/website_settings/permission_bubble_manager.cc

diff --git a/chrome/browser/ui/website_settings/permission_bubble_manager.cc b/chrome/browser/ui/website_settings/permission_bubble_manager.cc

index 9eec3bbe58351f6b0a56a202aaf5be401248f832..8816cee26ffea3ff1ebdfce6c6eca5b28a27a6e7 100644

--- a/chrome/browser/ui/website_settings/permission_bubble_manager.cc

+++ b/chrome/browser/ui/website_settings/permission_bubble_manager.cc

@@ -234,8 +234,7 @@ void PermissionBubbleManager::NavigationEntryCommitted(

}

-void PermissionBubbleManager::WebContentsDestroyed(

- content::WebContents* web_contents) {

+void PermissionBubbleManager::WebContentsDestroyed() {

// If the web contents has been destroyed, treat the bubble as cancelled.

CancelPendingQueue();

FinalizeBubble();

@@ -243,7 +242,7 @@ void PermissionBubbleManager::WebContentsDestroyed(

// The WebContents is going away; be aggressively paranoid and delete

// ourselves lest other parts of the system attempt to add permission bubbles

// or use us otherwise during the destruction.

- web_contents->RemoveUserData(UserDataKey());

+ web_contents()->RemoveUserData(UserDataKey());

// That was the equivalent of "delete this". This object is now destroyed;

// returning from this function is the only safe thing to do.

}