chrome/browser/ui/auto_login_infobar_delegate.cc - Issue 257153003: We have a problem in the process on destroying WebContentsImpl because

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/auto_login_infobar_delegate.cc

Issue 257153003: We have a problem in the process on destroying WebContentsImpl because (Closed) Base URL: https://git.chromium.org/chromium/src.git@master

Patch Set: Rebased onto origin/master again, resolved conflicts Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc ('k') | chrome/browser/ui/autofill/autofill_popup_controller_interactive_uitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/auto_login_infobar_delegate.cc

diff --git a/chrome/browser/ui/auto_login_infobar_delegate.cc b/chrome/browser/ui/auto_login_infobar_delegate.cc

index 11490295776ca2074562952cc3719ce6f92b2328..62dffb6efbb260391982279cd696cfbe359df652 100644

--- a/chrome/browser/ui/auto_login_infobar_delegate.cc

+++ b/chrome/browser/ui/auto_login_infobar_delegate.cc

@@ -63,8 +63,7 @@ class AutoLoginRedirector : public UbertokenConsumer,

virtual void OnUbertokenFailure(const GoogleServiceAuthError& error) OVERRIDE;

// Implementation of content::WebContentsObserver

- virtual void WebContentsDestroyed(

- content::WebContents* web_contents) OVERRIDE;

+ virtual void WebContentsDestroyed() OVERRIDE;

// Redirect tab to MergeSession URL, logging the user in and navigating

// to the desired page.

@@ -97,8 +96,7 @@ AutoLoginRedirector::AutoLoginRedirector(

AutoLoginRedirector::~AutoLoginRedirector() {

}

-void AutoLoginRedirector::WebContentsDestroyed(

- content::WebContents* web_contents) {

+void AutoLoginRedirector::WebContentsDestroyed() {

// The WebContents that started this has been destroyed. The request must be

// cancelled and this object must be deleted.

ubertoken_fetcher_.reset();