chrome/browser/ui/ash/launcher/browser_status_monitor.cc - Issue 257153003: We have a problem in the process on destroying WebContentsImpl because

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/ash/launcher/browser_status_monitor.cc

Issue 257153003: We have a problem in the process on destroying WebContentsImpl because (Closed) Base URL: https://git.chromium.org/chromium/src.git@master

Patch Set: Rebased onto origin/master again, resolved conflicts Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/android/infobars/auto_login_prompter.cc ('k') | chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/ash/launcher/browser_status_monitor.cc

diff --git a/chrome/browser/ui/ash/launcher/browser_status_monitor.cc b/chrome/browser/ui/ash/launcher/browser_status_monitor.cc

index f10792cb08257a9bcb6ab4bfa4968a64dad7231e..36b1935a14f8091ef9a8a5fffa3946577e9d3842 100644

--- a/chrome/browser/ui/ash/launcher/browser_status_monitor.cc

+++ b/chrome/browser/ui/ash/launcher/browser_status_monitor.cc

@@ -60,14 +60,11 @@ class BrowserStatusMonitor::LocalWebContentsObserver

monitor_->SetShelfIDForBrowserWindowContents(browser, web_contents());

}

- virtual void WebContentsDestroyed(

- content::WebContents* web_content) OVERRIDE {

- if (web_content == web_contents()) {

- // We can only come here when there was a non standard termination like

- // an app got un-installed while running, etc.

- monitor_->WebContentsDestroyed(web_content);

- // |this| is gone now.

- }

+ virtual void WebContentsDestroyed() OVERRIDE {

+ // We can only come here when there was a non standard termination like

+ // an app got un-installed while running, etc.

+ monitor_->WebContentsDestroyed(web_contents());

+ // |this| is gone now.

}

private: