chrome/browser/translate/translate_tab_helper.cc - Issue 257153003: We have a problem in the process on destroying WebContentsImpl because

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/translate/translate_tab_helper.cc

Issue 257153003: We have a problem in the process on destroying WebContentsImpl because (Closed) Base URL: https://git.chromium.org/chromium/src.git@master

Patch Set: Rebased onto origin/master again, resolved conflicts Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/translate/translate_tab_helper.cc

diff --git a/chrome/browser/translate/translate_tab_helper.cc b/chrome/browser/translate/translate_tab_helper.cc

index 9af958f7b6ceab7d2bbc68d2d7b953519b537c24..5ecd089f4aeea67356d65fa06a5ef40822c142db 100644

--- a/chrome/browser/translate/translate_tab_helper.cc

+++ b/chrome/browser/translate/translate_tab_helper.cc

@@ -301,8 +301,7 @@ void TranslateTabHelper::DidNavigateAnyFrame(

translate_driver_.DidNavigate(details);

}

-void TranslateTabHelper::WebContentsDestroyed(

- content::WebContents* web_contents) {

+void TranslateTabHelper::WebContentsDestroyed() {

// Translation process can be interrupted.

// Destroying the TranslateManager now guarantees that it never has to deal

// with NULL WebContents.

« no previous file with comments | « chrome/browser/translate/translate_tab_helper.h ('k') | chrome/browser/ui/android/infobars/auto_login_prompter.h » ('j') | no next file with comments »