Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(797)

Side by Side Diff: chrome/browser/ui/passwords/manage_passwords_bubble_ui_controller.h

Issue 257153003: We have a problem in the process on destroying WebContentsImpl because (Closed) Base URL: https://git.chromium.org/chromium/src.git@master
Patch Set: Removed what was added in https://codereview.chromium.org/239393009 Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_PASSWORDS_MANAGE_PASSWORDS_BUBBLE_UI_CONTROLLER_H_ 5 #ifndef CHROME_BROWSER_UI_PASSWORDS_MANAGE_PASSWORDS_BUBBLE_UI_CONTROLLER_H_
6 #define CHROME_BROWSER_UI_PASSWORDS_MANAGE_PASSWORDS_BUBBLE_UI_CONTROLLER_H_ 6 #define CHROME_BROWSER_UI_PASSWORDS_MANAGE_PASSWORDS_BUBBLE_UI_CONTROLLER_H_
7 7
8 #include "components/password_manager/core/browser/password_form_manager.h" 8 #include "components/password_manager/core/browser/password_form_manager.h"
9 #include "components/password_manager/core/browser/password_store.h" 9 #include "components/password_manager/core/browser/password_store.h"
10 #include "components/password_manager/core/browser/password_store_change.h" 10 #include "components/password_manager/core/browser/password_store_change.h"
(...skipping 87 matching lines...) Expand 10 before | Expand all | Expand 10 after
98 98
99 // Called when a passwordform is autofilled, when a new passwordform is 99 // Called when a passwordform is autofilled, when a new passwordform is
100 // submitted, or when a navigation occurs to update the visibility of the 100 // submitted, or when a navigation occurs to update the visibility of the
101 // manage passwords icon and bubble. 101 // manage passwords icon and bubble.
102 void UpdateBubbleAndIconVisibility(); 102 void UpdateBubbleAndIconVisibility();
103 103
104 // content::WebContentsObserver: 104 // content::WebContentsObserver:
105 virtual void DidNavigateMainFrame( 105 virtual void DidNavigateMainFrame(
106 const content::LoadCommittedDetails& details, 106 const content::LoadCommittedDetails& details,
107 const content::FrameNavigateParams& params) OVERRIDE; 107 const content::FrameNavigateParams& params) OVERRIDE;
108 virtual void WebContentsDestroyed( 108 virtual void WebContentsDestroyed() OVERRIDE;
109 content::WebContents* web_contents) OVERRIDE;
110 109
111 // Set by OnPasswordSubmitted() when the user submits a form containing login 110 // Set by OnPasswordSubmitted() when the user submits a form containing login
112 // information. If the user responds to a subsequent "Do you want to save 111 // information. If the user responds to a subsequent "Do you want to save
113 // this password?" prompt, we ask this object to save or blacklist the 112 // this password?" prompt, we ask this object to save or blacklist the
114 // associated login information in Chrome's password store. 113 // associated login information in Chrome's password store.
115 scoped_ptr<password_manager::PasswordFormManager> form_manager_; 114 scoped_ptr<password_manager::PasswordFormManager> form_manager_;
116 115
117 // All previously stored credentials for a specific site. Set by 116 // All previously stored credentials for a specific site. Set by
118 // OnPasswordSubmitted() or OnPasswordAutofilled(). 117 // OnPasswordSubmitted() or OnPasswordAutofilled().
119 autofill::PasswordFormMap password_form_map_; 118 autofill::PasswordFormMap password_form_map_;
120 119
121 bool manage_passwords_icon_to_be_shown_; 120 bool manage_passwords_icon_to_be_shown_;
122 bool password_to_be_saved_; 121 bool password_to_be_saved_;
123 bool manage_passwords_bubble_needs_showing_; 122 bool manage_passwords_bubble_needs_showing_;
124 123
125 // Stores whether autofill was blocked due to a user's decision to blacklist 124 // Stores whether autofill was blocked due to a user's decision to blacklist
126 // the current site ("Never save passwords for this site"). 125 // the current site ("Never save passwords for this site").
127 bool autofill_blocked_; 126 bool autofill_blocked_;
128 127
129 // The origin of the form we're currently dealing with; we'll use this to 128 // The origin of the form we're currently dealing with; we'll use this to
130 // determine which PasswordStore changes we should care about when updating 129 // determine which PasswordStore changes we should care about when updating
131 // |password_form_map_|. 130 // |password_form_map_|.
132 GURL origin_; 131 GURL origin_;
133 132
134 DISALLOW_COPY_AND_ASSIGN(ManagePasswordsBubbleUIController); 133 DISALLOW_COPY_AND_ASSIGN(ManagePasswordsBubbleUIController);
135 }; 134 };
136 135
137 #endif // CHROME_BROWSER_UI_PASSWORDS_MANAGE_PASSWORDS_BUBBLE_UI_CONTROLLER_H_ 136 #endif // CHROME_BROWSER_UI_PASSWORDS_MANAGE_PASSWORDS_BUBBLE_UI_CONTROLLER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698