chrome/browser/ui/passwords/manage_passwords_bubble_model.h - Issue 257153003: We have a problem in the process on destroying WebContentsImpl because

Side by Side Diff: chrome/browser/ui/passwords/manage_passwords_bubble_model.h

Issue 257153003: We have a problem in the process on destroying WebContentsImpl because (Closed) Base URL: https://git.chromium.org/chromium/src.git@master

Patch Set: Removed what was added in https://codereview.chromium.org/239393009 Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/ui/autofill/autofill_popup_controller_interactive_uitest.cc ('K') | « chrome/browser/ui/panels/panel_host.cc ('k') | chrome/browser/ui/passwords/manage_passwords_bubble_model.cc » ('j') | content/public/browser/web_contents_observer.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2013 The Chromium Authors. All rights reserved.	1 // Copyright 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROME_BROWSER_UI_PASSWORDS_MANAGE_PASSWORDS_BUBBLE_MODEL_H_	5 #ifndef CHROME_BROWSER_UI_PASSWORDS_MANAGE_PASSWORDS_BUBBLE_MODEL_H_

6 #define CHROME_BROWSER_UI_PASSWORDS_MANAGE_PASSWORDS_BUBBLE_MODEL_H_	6 #define CHROME_BROWSER_UI_PASSWORDS_MANAGE_PASSWORDS_BUBBLE_MODEL_H_

7	7

8 #include "chrome/browser/ui/passwords/manage_passwords_bubble.h"	8 #include "chrome/browser/ui/passwords/manage_passwords_bubble.h"

9 #include "components/autofill/core/common/password_form.h"	9 #include "components/autofill/core/common/password_form.h"

10 #include "components/password_manager/core/browser/password_manager_metrics_util .h"	10 #include "components/password_manager/core/browser/password_manager_metrics_util .h"

(...skipping 82 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
93 return dismissal_reason_;	93 return dismissal_reason_;

94 }	94 }

95	95

96 // State setter; exposed for testing.	96 // State setter; exposed for testing.

97 void set_manage_passwords_bubble_state(ManagePasswordsBubbleState state) {	97 void set_manage_passwords_bubble_state(ManagePasswordsBubbleState state) {

98 manage_passwords_bubble_state_ = state;	98 manage_passwords_bubble_state_ = state;

99 }	99 }

100	100

101 private:	101 private:

102 // content::WebContentsObserver	102 // content::WebContentsObserver

103 virtual void WebContentsDestroyed(	103 virtual void WebContentsDestroyed() OVERRIDE;

104 content::WebContents* web_contents) OVERRIDE;

105	104

106 content::WebContents* web_contents_;	105 content::WebContents* web_contents_;
	jam 2014/05/05 17:46:46 need to remove this also need to remove this also zverre 2014/05/06 09:37:26 Done. Show quoted text On 2014/05/05 17:46:46, jam wrote: > need to remove this also Done.
107 ManagePasswordsBubbleState manage_passwords_bubble_state_;	106 ManagePasswordsBubbleState manage_passwords_bubble_state_;

108 base::string16 title_;	107 base::string16 title_;

109 autofill::PasswordForm pending_credentials_;	108 autofill::PasswordForm pending_credentials_;

110 autofill::PasswordFormMap best_matches_;	109 autofill::PasswordFormMap best_matches_;

111 base::string16 manage_link_;	110 base::string16 manage_link_;

112	111

113 password_manager::metrics_util::UIDisplayDisposition display_disposition_;	112 password_manager::metrics_util::UIDisplayDisposition display_disposition_;

114 password_manager::metrics_util::UIDismissalReason dismissal_reason_;	113 password_manager::metrics_util::UIDismissalReason dismissal_reason_;

115	114

116 DISALLOW_COPY_AND_ASSIGN(ManagePasswordsBubbleModel);	115 DISALLOW_COPY_AND_ASSIGN(ManagePasswordsBubbleModel);

117 };	116 };

118	117

119 #endif // CHROME_BROWSER_UI_PASSWORDS_MANAGE_PASSWORDS_BUBBLE_MODEL_H_	118 #endif // CHROME_BROWSER_UI_PASSWORDS_MANAGE_PASSWORDS_BUBBLE_MODEL_H_

OLD	NEW