chrome/browser/ui/panels/panel_host.h - Issue 257153003: We have a problem in the process on destroying WebContentsImpl because

Side by Side Diff: chrome/browser/ui/panels/panel_host.h

Issue 257153003: We have a problem in the process on destroying WebContentsImpl because (Closed) Base URL: https://git.chromium.org/chromium/src.git@master

Patch Set: Removed what was added in https://codereview.chromium.org/239393009 Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/ui/autofill/autofill_popup_controller_interactive_uitest.cc ('K') | « chrome/browser/ui/omnibox/omnibox_navigation_observer.cc ('k') | chrome/browser/ui/panels/panel_host.cc » ('j') | chrome/browser/ui/passwords/manage_passwords_bubble_model.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROME_BROWSER_UI_PANELS_PANEL_HOST_H_	5 #ifndef CHROME_BROWSER_UI_PANELS_PANEL_HOST_H_

6 #define CHROME_BROWSER_UI_PANELS_PANEL_HOST_H_	6 #define CHROME_BROWSER_UI_PANELS_PANEL_HOST_H_

7	7

8 #include "base/memory/scoped_ptr.h"	8 #include "base/memory/scoped_ptr.h"

9 #include "base/memory/weak_ptr.h"	9 #include "base/memory/weak_ptr.h"

10 #include "content/public/browser/web_contents_delegate.h"	10 #include "content/public/browser/web_contents_delegate.h"

(...skipping 62 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
73 content::WebContents* source,	73 content::WebContents* source,

74 const content::NativeWebKeyboardEvent& event) OVERRIDE;	74 const content::NativeWebKeyboardEvent& event) OVERRIDE;

75 virtual void WebContentsFocused(content::WebContents* contents) OVERRIDE;	75 virtual void WebContentsFocused(content::WebContents* contents) OVERRIDE;

76 virtual void ResizeDueToAutoResize(content::WebContents* web_contents,	76 virtual void ResizeDueToAutoResize(content::WebContents* web_contents,

77 const gfx::Size& new_size) OVERRIDE;	77 const gfx::Size& new_size) OVERRIDE;

78	78

79 // content::WebContentsObserver overrides.	79 // content::WebContentsObserver overrides.

80 virtual void RenderViewCreated(	80 virtual void RenderViewCreated(

81 content::RenderViewHost* render_view_host) OVERRIDE;	81 content::RenderViewHost* render_view_host) OVERRIDE;

82 virtual void RenderProcessGone(base::TerminationStatus status) OVERRIDE;	82 virtual void RenderProcessGone(base::TerminationStatus status) OVERRIDE;

83 virtual void WebContentsDestroyed(	83 virtual void WebContentsDestroyed() OVERRIDE;

84 content::WebContents* web_contents) OVERRIDE;

85 virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE;	84 virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE;

86	85

87 // extensions::ExtensionFunctionDispatcher::Delegate overrides.	86 // extensions::ExtensionFunctionDispatcher::Delegate overrides.

88 virtual extensions::WindowController* GetExtensionWindowController() const	87 virtual extensions::WindowController* GetExtensionWindowController() const

89 OVERRIDE;	88 OVERRIDE;

90 virtual content::WebContents* GetAssociatedWebContents() const OVERRIDE;	89 virtual content::WebContents* GetAssociatedWebContents() const OVERRIDE;

91	90

92 // Actions on web contents.	91 // Actions on web contents.

93 void Reload();	92 void Reload();

94 void ReloadIgnoringCache();	93 void ReloadIgnoringCache();

(...skipping 13 matching lines...) Expand all Loading...
108	107

109 scoped_ptr<content::WebContents> web_contents_;	108 scoped_ptr<content::WebContents> web_contents_;

110	109

111 // The following factory is used to close the panel via the message loop.	110 // The following factory is used to close the panel via the message loop.

112 base::WeakPtrFactory<PanelHost> weak_factory_;	111 base::WeakPtrFactory<PanelHost> weak_factory_;

113	112

114 DISALLOW_COPY_AND_ASSIGN(PanelHost);	113 DISALLOW_COPY_AND_ASSIGN(PanelHost);

115 };	114 };

116	115

117 #endif // CHROME_BROWSER_UI_PANELS_PANEL_HOST_H_	116 #endif // CHROME_BROWSER_UI_PANELS_PANEL_HOST_H_

OLD	NEW