Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Side by Side Diff: chrome/browser/ui/website_settings/permission_bubble_manager.h

Issue 257153003: We have a problem in the process on destroying WebContentsImpl because (Closed) Base URL: https://git.chromium.org/chromium/src.git@master
Patch Set: Rebased onto origin/lkgr Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_WEBSITE_SETTINGS_PERMISSION_BUBBLE_MANAGER_H_ 5 #ifndef CHROME_BROWSER_UI_WEBSITE_SETTINGS_PERMISSION_BUBBLE_MANAGER_H_
6 #define CHROME_BROWSER_UI_WEBSITE_SETTINGS_PERMISSION_BUBBLE_MANAGER_H_ 6 #define CHROME_BROWSER_UI_WEBSITE_SETTINGS_PERMISSION_BUBBLE_MANAGER_H_
7 7
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/memory/weak_ptr.h" 10 #include "base/memory/weak_ptr.h"
(...skipping 55 matching lines...) Expand 10 before | Expand all | Expand 10 after
66 // WebContentsObserver: 66 // WebContentsObserver:
67 67
68 // TODO(leng): Finalize policy for permission requests with iFrames. 68 // TODO(leng): Finalize policy for permission requests with iFrames.
69 // DocumentLoadedInFrame() might be needed as well. 69 // DocumentLoadedInFrame() might be needed as well.
70 virtual void DocumentOnLoadCompletedInMainFrame(int32 page_id) OVERRIDE; 70 virtual void DocumentOnLoadCompletedInMainFrame(int32 page_id) OVERRIDE;
71 71
72 // If a page on which permissions requests are pending is navigated, 72 // If a page on which permissions requests are pending is navigated,
73 // they will be finalized as if canceled by the user. 73 // they will be finalized as if canceled by the user.
74 virtual void NavigationEntryCommitted( 74 virtual void NavigationEntryCommitted(
75 const content::LoadCommittedDetails& details) OVERRIDE; 75 const content::LoadCommittedDetails& details) OVERRIDE;
76 virtual void WebContentsDestroyed( 76 virtual void WebContentsDestroyed() OVERRIDE;
77 content::WebContents* web_contents) OVERRIDE;
78 77
79 // PermissionBubbleView::Delegate: 78 // PermissionBubbleView::Delegate:
80 virtual void ToggleAccept(int request_index, bool new_value) OVERRIDE; 79 virtual void ToggleAccept(int request_index, bool new_value) OVERRIDE;
81 virtual void SetCustomizationMode() OVERRIDE; 80 virtual void SetCustomizationMode() OVERRIDE;
82 virtual void Accept() OVERRIDE; 81 virtual void Accept() OVERRIDE;
83 virtual void Deny() OVERRIDE; 82 virtual void Deny() OVERRIDE;
84 virtual void Closing() OVERRIDE; 83 virtual void Closing() OVERRIDE;
85 84
86 void ShowBubble(); 85 void ShowBubble();
87 86
(...skipping 15 matching lines...) Expand all
103 std::vector<PermissionBubbleRequest*> queued_requests_; 102 std::vector<PermissionBubbleRequest*> queued_requests_;
104 GURL request_url_; 103 GURL request_url_;
105 bool request_url_has_loaded_; 104 bool request_url_has_loaded_;
106 std::vector<bool> accept_states_; 105 std::vector<bool> accept_states_;
107 bool customization_mode_; 106 bool customization_mode_;
108 107
109 base::WeakPtrFactory<PermissionBubbleManager> weak_factory_; 108 base::WeakPtrFactory<PermissionBubbleManager> weak_factory_;
110 }; 109 };
111 110
112 #endif // CHROME_BROWSER_UI_WEBSITE_SETTINGS_PERMISSION_BUBBLE_MANAGER_H_ 111 #endif // CHROME_BROWSER_UI_WEBSITE_SETTINGS_PERMISSION_BUBBLE_MANAGER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698