Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Side by Side Diff: content/public/browser/web_contents_observer.cc

Issue 257153003: We have a problem in the process on destroying WebContentsImpl because (Closed) Base URL: https://git.chromium.org/chromium/src.git@master
Patch Set: Rebased onto origin/master again, resolved conflicts Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/public/browser/web_contents_observer.h" 5 #include "content/public/browser/web_contents_observer.h"
6 6
7 #include "content/browser/web_contents/web_contents_impl.h" 7 #include "content/browser/web_contents/web_contents_impl.h"
8 #include "content/public/browser/navigation_details.h" 8 #include "content/public/browser/navigation_details.h"
9 #include "content/public/browser/render_view_host.h" 9 #include "content/public/browser/render_view_host.h"
10 10
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
60 return web_contents_->Send(message); 60 return web_contents_->Send(message);
61 } 61 }
62 62
63 int WebContentsObserver::routing_id() const { 63 int WebContentsObserver::routing_id() const {
64 if (!web_contents_) 64 if (!web_contents_)
65 return MSG_ROUTING_NONE; 65 return MSG_ROUTING_NONE;
66 66
67 return web_contents_->GetRoutingID(); 67 return web_contents_->GetRoutingID();
68 } 68 }
69 69
70 void WebContentsObserver::WebContentsImplDestroyed() { 70 void WebContentsObserver::ResetWebContents() {
71 // Do cleanup so that 'this' can safely be deleted from WebContentsDestroyed.
72 web_contents_->RemoveObserver(this); 71 web_contents_->RemoveObserver(this);
73 WebContentsImpl* contents = web_contents_;
74 web_contents_ = NULL; 72 web_contents_ = NULL;
75 WebContentsDestroyed(contents);
76 } 73 }
77 74
78 } // namespace content 75 } // namespace content
OLDNEW
« no previous file with comments | « content/public/browser/web_contents_observer.h ('k') | content/public/test/browser_test_utils.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698