Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Side by Side Diff: chrome/browser/ui/website_settings/permission_bubble_manager.h

Issue 257153003: We have a problem in the process on destroying WebContentsImpl because (Closed) Base URL: https://git.chromium.org/chromium/src.git@master
Patch Set: Rebased onto origin/master again, resolved conflicts Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_WEBSITE_SETTINGS_PERMISSION_BUBBLE_MANAGER_H_ 5 #ifndef CHROME_BROWSER_UI_WEBSITE_SETTINGS_PERMISSION_BUBBLE_MANAGER_H_
6 #define CHROME_BROWSER_UI_WEBSITE_SETTINGS_PERMISSION_BUBBLE_MANAGER_H_ 6 #define CHROME_BROWSER_UI_WEBSITE_SETTINGS_PERMISSION_BUBBLE_MANAGER_H_
7 7
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/memory/weak_ptr.h" 10 #include "base/memory/weak_ptr.h"
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
67 // WebContentsObserver: 67 // WebContentsObserver:
68 68
69 // TODO(leng): Finalize policy for permission requests with iFrames. 69 // TODO(leng): Finalize policy for permission requests with iFrames.
70 // DocumentLoadedInFrame() might be needed as well. 70 // DocumentLoadedInFrame() might be needed as well.
71 virtual void DocumentOnLoadCompletedInMainFrame() OVERRIDE; 71 virtual void DocumentOnLoadCompletedInMainFrame() OVERRIDE;
72 72
73 // If a page on which permissions requests are pending is navigated, 73 // If a page on which permissions requests are pending is navigated,
74 // they will be finalized as if canceled by the user. 74 // they will be finalized as if canceled by the user.
75 virtual void NavigationEntryCommitted( 75 virtual void NavigationEntryCommitted(
76 const content::LoadCommittedDetails& details) OVERRIDE; 76 const content::LoadCommittedDetails& details) OVERRIDE;
77 virtual void WebContentsDestroyed( 77 virtual void WebContentsDestroyed() OVERRIDE;
78 content::WebContents* web_contents) OVERRIDE;
79 78
80 // PermissionBubbleView::Delegate: 79 // PermissionBubbleView::Delegate:
81 virtual void ToggleAccept(int request_index, bool new_value) OVERRIDE; 80 virtual void ToggleAccept(int request_index, bool new_value) OVERRIDE;
82 virtual void SetCustomizationMode() OVERRIDE; 81 virtual void SetCustomizationMode() OVERRIDE;
83 virtual void Accept() OVERRIDE; 82 virtual void Accept() OVERRIDE;
84 virtual void Deny() OVERRIDE; 83 virtual void Deny() OVERRIDE;
85 virtual void Closing() OVERRIDE; 84 virtual void Closing() OVERRIDE;
86 85
87 void ShowBubble(); 86 void ShowBubble();
88 87
(...skipping 19 matching lines...) Expand all
108 GURL request_url_; 107 GURL request_url_;
109 bool request_url_has_loaded_; 108 bool request_url_has_loaded_;
110 109
111 std::vector<bool> accept_states_; 110 std::vector<bool> accept_states_;
112 bool customization_mode_; 111 bool customization_mode_;
113 112
114 base::WeakPtrFactory<PermissionBubbleManager> weak_factory_; 113 base::WeakPtrFactory<PermissionBubbleManager> weak_factory_;
115 }; 114 };
116 115
117 #endif // CHROME_BROWSER_UI_WEBSITE_SETTINGS_PERMISSION_BUBBLE_MANAGER_H_ 116 #endif // CHROME_BROWSER_UI_WEBSITE_SETTINGS_PERMISSION_BUBBLE_MANAGER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698