Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Side by Side Diff: chrome/browser/ui/views/hung_renderer_view.h

Issue 257153003: We have a problem in the process on destroying WebContentsImpl because (Closed) Base URL: https://git.chromium.org/chromium/src.git@master
Patch Set: Rebased onto origin/master again, resolved conflicts Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_VIEWS_HUNG_RENDERER_VIEW_H_ 5 #ifndef CHROME_BROWSER_UI_VIEWS_HUNG_RENDERER_VIEW_H_
6 #define CHROME_BROWSER_UI_VIEWS_HUNG_RENDERER_VIEW_H_ 6 #define CHROME_BROWSER_UI_VIEWS_HUNG_RENDERER_VIEW_H_
7 7
8 #include "base/memory/scoped_vector.h" 8 #include "base/memory/scoped_vector.h"
9 #include "chrome/browser/favicon/favicon_tab_helper.h" 9 #include "chrome/browser/favicon/favicon_tab_helper.h"
10 #include "content/public/browser/web_contents_observer.h" 10 #include "content/public/browser/web_contents_observer.h"
(...skipping 57 matching lines...) Expand 10 before | Expand all | Expand 10 after
68 content::WebContents* web_contents() const { 68 content::WebContents* web_contents() const {
69 return content::WebContentsObserver::web_contents(); 69 return content::WebContentsObserver::web_contents();
70 } 70 }
71 71
72 FaviconTabHelper* favicon_tab_helper() { 72 FaviconTabHelper* favicon_tab_helper() {
73 return FaviconTabHelper::FromWebContents(web_contents()); 73 return FaviconTabHelper::FromWebContents(web_contents());
74 } 74 }
75 75
76 // WebContentsObserver overrides: 76 // WebContentsObserver overrides:
77 virtual void RenderProcessGone(base::TerminationStatus status) OVERRIDE; 77 virtual void RenderProcessGone(base::TerminationStatus status) OVERRIDE;
78 virtual void WebContentsDestroyed(content::WebContents* tab) OVERRIDE; 78 virtual void WebContentsDestroyed() OVERRIDE;
79 79
80 private: 80 private:
81 HungPagesTableModel* model_; 81 HungPagesTableModel* model_;
82 82
83 DISALLOW_COPY_AND_ASSIGN(WebContentsObserverImpl); 83 DISALLOW_COPY_AND_ASSIGN(WebContentsObserverImpl);
84 }; 84 };
85 85
86 // Invoked when a WebContents is destroyed. Cleans up |tab_observers_| and 86 // Invoked when a WebContents is destroyed. Cleans up |tab_observers_| and
87 // notifies the observer and delegate. 87 // notifies the observer and delegate.
88 void TabDestroyed(WebContentsObserverImpl* tab); 88 void TabDestroyed(WebContentsObserverImpl* tab);
(...skipping 76 matching lines...) Expand 10 before | Expand all | Expand 10 after
165 // Whether or not we've created controls for ourself. 165 // Whether or not we've created controls for ourself.
166 bool initialized_; 166 bool initialized_;
167 167
168 // An amusing icon image. 168 // An amusing icon image.
169 static gfx::ImageSkia* frozen_icon_; 169 static gfx::ImageSkia* frozen_icon_;
170 170
171 DISALLOW_COPY_AND_ASSIGN(HungRendererDialogView); 171 DISALLOW_COPY_AND_ASSIGN(HungRendererDialogView);
172 }; 172 };
173 173
174 #endif // CHROME_BROWSER_UI_VIEWS_HUNG_RENDERER_VIEW_H_ 174 #endif // CHROME_BROWSER_UI_VIEWS_HUNG_RENDERER_VIEW_H_
OLDNEW
« no previous file with comments | « chrome/browser/ui/views/frame/browser_view_browsertest.cc ('k') | chrome/browser/ui/views/hung_renderer_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698