Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Side by Side Diff: chrome/browser/ui/views/hung_renderer_view.cc

Issue 257153003: We have a problem in the process on destroying WebContentsImpl because (Closed) Base URL: https://git.chromium.org/chromium/src.git@master
Patch Set: Rebased onto origin/master again, resolved conflicts Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/views/hung_renderer_view.h" 5 #include "chrome/browser/ui/views/hung_renderer_view.h"
6 6
7 #include "base/i18n/rtl.h" 7 #include "base/i18n/rtl.h"
8 #include "base/memory/scoped_vector.h" 8 #include "base/memory/scoped_vector.h"
9 #include "base/strings/utf_string_conversions.h" 9 #include "base/strings/utf_string_conversions.h"
10 #include "chrome/browser/favicon/favicon_tab_helper.h" 10 #include "chrome/browser/favicon/favicon_tab_helper.h"
(...skipping 137 matching lines...) Expand 10 before | Expand all | Expand 10 after
148 HungPagesTableModel* model, WebContents* tab) 148 HungPagesTableModel* model, WebContents* tab)
149 : content::WebContentsObserver(tab), 149 : content::WebContentsObserver(tab),
150 model_(model) { 150 model_(model) {
151 } 151 }
152 152
153 void HungPagesTableModel::WebContentsObserverImpl::RenderProcessGone( 153 void HungPagesTableModel::WebContentsObserverImpl::RenderProcessGone(
154 base::TerminationStatus status) { 154 base::TerminationStatus status) {
155 model_->TabDestroyed(this); 155 model_->TabDestroyed(this);
156 } 156 }
157 157
158 void HungPagesTableModel::WebContentsObserverImpl::WebContentsDestroyed( 158 void HungPagesTableModel::WebContentsObserverImpl::WebContentsDestroyed() {
159 WebContents* tab) {
160 model_->TabDestroyed(this); 159 model_->TabDestroyed(this);
161 } 160 }
162 161
163 /////////////////////////////////////////////////////////////////////////////// 162 ///////////////////////////////////////////////////////////////////////////////
164 // HungRendererDialogView 163 // HungRendererDialogView
165 164
166 // static 165 // static
167 gfx::ImageSkia* HungRendererDialogView::frozen_icon_ = NULL; 166 gfx::ImageSkia* HungRendererDialogView::frozen_icon_ = NULL;
168 167
169 // The dimensions of the hung pages list table view, in pixels. 168 // The dimensions of the hung pages list table view, in pixels.
(...skipping 279 matching lines...) Expand 10 before | Expand all | Expand 10 after
449 HungRendererDialogView* view = HungRendererDialogView::Create(toplevel_view); 448 HungRendererDialogView* view = HungRendererDialogView::Create(toplevel_view);
450 view->ShowForWebContents(contents); 449 view->ShowForWebContents(contents);
451 } 450 }
452 451
453 void HideHungRendererDialog(WebContents* contents) { 452 void HideHungRendererDialog(WebContents* contents) {
454 if (!logging::DialogsAreSuppressed() && HungRendererDialogView::GetInstance()) 453 if (!logging::DialogsAreSuppressed() && HungRendererDialogView::GetInstance())
455 HungRendererDialogView::GetInstance()->EndForWebContents(contents); 454 HungRendererDialogView::GetInstance()->EndForWebContents(contents);
456 } 455 }
457 456
458 } // namespace chrome 457 } // namespace chrome
OLDNEW
« no previous file with comments | « chrome/browser/ui/views/hung_renderer_view.h ('k') | chrome/browser/ui/views/translate/translate_bubble_view.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698