Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Side by Side Diff: chrome/browser/task_manager/web_contents_resource_provider.cc

Issue 257153003: We have a problem in the process on destroying WebContentsImpl because (Closed) Base URL: https://git.chromium.org/chromium/src.git@master
Patch Set: Rebased onto origin/master again, resolved conflicts Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/task_manager/web_contents_resource_provider.h" 5 #include "chrome/browser/task_manager/web_contents_resource_provider.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/bind_helpers.h" 8 #include "base/bind_helpers.h"
9 #include "chrome/browser/browser_process.h" 9 #include "chrome/browser/browser_process.h"
10 #include "chrome/browser/prerender/prerender_manager.h" 10 #include "chrome/browser/prerender/prerender_manager.h"
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
44 44
45 virtual void RenderViewReady() OVERRIDE { 45 virtual void RenderViewReady() OVERRIDE {
46 provider_->RemoveFromTaskManager(web_contents()); 46 provider_->RemoveFromTaskManager(web_contents());
47 provider_->AddToTaskManager(web_contents()); 47 provider_->AddToTaskManager(web_contents());
48 } 48 }
49 49
50 virtual void RenderProcessGone(base::TerminationStatus status) OVERRIDE { 50 virtual void RenderProcessGone(base::TerminationStatus status) OVERRIDE {
51 provider_->RemoveFromTaskManager(web_contents()); 51 provider_->RemoveFromTaskManager(web_contents());
52 } 52 }
53 53
54 virtual void WebContentsDestroyed(WebContents* web_contents) OVERRIDE { 54 virtual void WebContentsDestroyed() OVERRIDE {
55 provider_->RemoveFromTaskManager(web_contents); 55 provider_->RemoveFromTaskManager(web_contents());
56 provider_->DeleteObserver(this); // Deletes |this|. 56 provider_->DeleteObserver(this); // Deletes |this|.
57 } 57 }
58 58
59 private: 59 private:
60 WebContentsResourceProvider* provider_; 60 WebContentsResourceProvider* provider_;
61 }; 61 };
62 62
63 //////////////////////////////////////////////////////////////////////////////// 63 ////////////////////////////////////////////////////////////////////////////////
64 // WebContentsResourceProvider class 64 // WebContentsResourceProvider class
65 //////////////////////////////////////////////////////////////////////////////// 65 ////////////////////////////////////////////////////////////////////////////////
(...skipping 120 matching lines...) Expand 10 before | Expand all | Expand 10 after
186 void WebContentsResourceProvider::DeleteObserver( 186 void WebContentsResourceProvider::DeleteObserver(
187 TaskManagerWebContentsObserver* observer) { 187 TaskManagerWebContentsObserver* observer) {
188 if (!web_contents_observers_.erase(observer)) { 188 if (!web_contents_observers_.erase(observer)) {
189 NOTREACHED(); 189 NOTREACHED();
190 return; 190 return;
191 } 191 }
192 delete observer; // Typically, this is our caller. Deletion is okay. 192 delete observer; // Typically, this is our caller. Deletion is okay.
193 } 193 }
194 194
195 } // namespace task_manager 195 } // namespace task_manager
OLDNEW
« no previous file with comments | « chrome/browser/safe_browsing/client_side_detection_host.cc ('k') | chrome/browser/translate/translate_tab_helper.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698