Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Side by Side Diff: chrome/browser/history/history_tab_helper.h

Issue 257153003: We have a problem in the process on destroying WebContentsImpl because (Closed) Base URL: https://git.chromium.org/chromium/src.git@master
Patch Set: Rebased onto origin/master again, resolved conflicts Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_HISTORY_HISTORY_TAB_HELPER_H_ 5 #ifndef CHROME_BROWSER_HISTORY_HISTORY_TAB_HELPER_H_
6 #define CHROME_BROWSER_HISTORY_HISTORY_TAB_HELPER_H_ 6 #define CHROME_BROWSER_HISTORY_HISTORY_TAB_HELPER_H_
7 7
8 #include "base/memory/ref_counted.h" 8 #include "base/memory/ref_counted.h"
9 #include "base/time/time.h" 9 #include "base/time/time.h"
10 #include "content/public/browser/web_contents_observer.h" 10 #include "content/public/browser/web_contents_observer.h"
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
44 44
45 // content::WebContentsObserver implementation. 45 // content::WebContentsObserver implementation.
46 virtual void DidNavigateMainFrame( 46 virtual void DidNavigateMainFrame(
47 const content::LoadCommittedDetails& details, 47 const content::LoadCommittedDetails& details,
48 const content::FrameNavigateParams& params) OVERRIDE; 48 const content::FrameNavigateParams& params) OVERRIDE;
49 virtual void DidNavigateAnyFrame( 49 virtual void DidNavigateAnyFrame(
50 const content::LoadCommittedDetails& details, 50 const content::LoadCommittedDetails& details,
51 const content::FrameNavigateParams& params) OVERRIDE; 51 const content::FrameNavigateParams& params) OVERRIDE;
52 virtual void TitleWasSet(content::NavigationEntry* entry, 52 virtual void TitleWasSet(content::NavigationEntry* entry,
53 bool explicit_set) OVERRIDE; 53 bool explicit_set) OVERRIDE;
54 virtual void WebContentsDestroyed(content::WebContents* tab) OVERRIDE; 54 virtual void WebContentsDestroyed() OVERRIDE;
55 55
56 // Helper function to return the history service. May return NULL. 56 // Helper function to return the history service. May return NULL.
57 HistoryService* GetHistoryService(); 57 HistoryService* GetHistoryService();
58 58
59 // Whether we have a (non-empty) title for the current page. 59 // Whether we have a (non-empty) title for the current page.
60 // Used to prevent subsequent title updates from affecting history. This 60 // Used to prevent subsequent title updates from affecting history. This
61 // prevents some weirdness because some AJAXy apps use titles for status 61 // prevents some weirdness because some AJAXy apps use titles for status
62 // messages. 62 // messages.
63 bool received_page_title_; 63 bool received_page_title_;
64 64
65 DISALLOW_COPY_AND_ASSIGN(HistoryTabHelper); 65 DISALLOW_COPY_AND_ASSIGN(HistoryTabHelper);
66 }; 66 };
67 67
68 #endif // CHROME_BROWSER_HISTORY_HISTORY_TAB_HELPER_H_ 68 #endif // CHROME_BROWSER_HISTORY_HISTORY_TAB_HELPER_H_
OLDNEW
« no previous file with comments | « chrome/browser/guest_view/web_view/web_view_guest.cc ('k') | chrome/browser/history/history_tab_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698