Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Side by Side Diff: chrome/browser/android/shortcut_helper.h

Issue 257153003: We have a problem in the process on destroying WebContentsImpl because (Closed) Base URL: https://git.chromium.org/chromium/src.git@master
Patch Set: Rebased onto origin/master again, resolved conflicts Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « android_webview/native/aw_settings.cc ('k') | chrome/browser/android/shortcut_helper.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_ANDROID_SHORTCUT_HELPER_H_ 5 #ifndef CHROME_BROWSER_ANDROID_SHORTCUT_HELPER_H_
6 #define CHROME_BROWSER_ANDROID_SHORTCUT_HELPER_H_ 6 #define CHROME_BROWSER_ANDROID_SHORTCUT_HELPER_H_
7 7
8 #include "base/android/jni_weak_ref.h" 8 #include "base/android/jni_weak_ref.h"
9 #include "base/basictypes.h" 9 #include "base/basictypes.h"
10 #include "base/strings/string16.h" 10 #include "base/strings/string16.h"
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
50 void OnDidRetrieveWebappInformation(bool success, 50 void OnDidRetrieveWebappInformation(bool success,
51 bool is_mobile_webapp_capable, 51 bool is_mobile_webapp_capable,
52 bool is_apple_mobile_webapp_capable, 52 bool is_apple_mobile_webapp_capable,
53 const GURL& expected_url); 53 const GURL& expected_url);
54 54
55 void FinishAddingShortcut( 55 void FinishAddingShortcut(
56 const favicon_base::FaviconBitmapResult& bitmap_result); 56 const favicon_base::FaviconBitmapResult& bitmap_result);
57 57
58 // WebContentsObserver 58 // WebContentsObserver
59 virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE; 59 virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE;
60 virtual void WebContentsDestroyed(content::WebContents* web_contents) 60 virtual void WebContentsDestroyed() OVERRIDE;
61 OVERRIDE;
62 61
63 private: 62 private:
64 void Destroy(); 63 void Destroy();
65 64
66 GURL url_; 65 GURL url_;
67 base::string16 title_; 66 base::string16 title_;
68 int launcher_large_icon_size_; 67 int launcher_large_icon_size_;
69 ShortcutType shortcut_type_; 68 ShortcutType shortcut_type_;
70 base::CancelableTaskTracker cancelable_task_tracker_; 69 base::CancelableTaskTracker cancelable_task_tracker_;
71 70
(...skipping 16 matching lines...) Expand all
88 const favicon_base::FaviconBitmapResult& bitmap_result); 87 const favicon_base::FaviconBitmapResult& bitmap_result);
89 88
90 // Registers JNI hooks. 89 // Registers JNI hooks.
91 static bool RegisterShortcutHelper(JNIEnv* env); 90 static bool RegisterShortcutHelper(JNIEnv* env);
92 91
93 private: 92 private:
94 DISALLOW_COPY_AND_ASSIGN(ShortcutHelper); 93 DISALLOW_COPY_AND_ASSIGN(ShortcutHelper);
95 }; 94 };
96 95
97 #endif // CHROME_BROWSER_ANDROID_SHORTCUT_HELPER_H_ 96 #endif // CHROME_BROWSER_ANDROID_SHORTCUT_HELPER_H_
OLDNEW
« no previous file with comments | « android_webview/native/aw_settings.cc ('k') | chrome/browser/android/shortcut_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698