Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Unified Diff: chrome/browser/chromeos/login/signin/device_id_browsertest.cc

Issue 2571473002: Fix cases where RunLoop is created without a MessageLoop. (Closed)
Patch Set: Fix chromeos tests. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/signin/device_id_browsertest.cc
diff --git a/chrome/browser/chromeos/login/signin/device_id_browsertest.cc b/chrome/browser/chromeos/login/signin/device_id_browsertest.cc
index 2c37e60ccc0f9932343c35f77e43261141d9f886..e35ece8cb2a66fdce668157157a0c4e7b32aff20 100644
--- a/chrome/browser/chromeos/login/signin/device_id_browsertest.cc
+++ b/chrome/browser/chromeos/login/signin/device_id_browsertest.cc
@@ -49,6 +49,7 @@ class DeviceIDTest : public OobeBaseTest,
}
void SetUpOnMainThread() override {
+ user_removal_loop_.reset(new base::RunLoop);
OobeBaseTest::SetUpOnMainThread();
LoadRefreshTokenToDeviceIdMap();
}
@@ -125,7 +126,7 @@ class DeviceIDTest : public OobeBaseTest,
void RemoveUser(const AccountId& account_id) {
user_manager::UserManager::Get()->RemoveUser(account_id, this);
- user_removal_loop_.Run();
+ user_removal_loop_->Run();
}
private:
@@ -133,7 +134,7 @@ class DeviceIDTest : public OobeBaseTest,
void OnBeforeUserRemoved(const AccountId& account_id) override {}
void OnUserRemoved(const AccountId& account_id) override {
- user_removal_loop_.Quit();
+ user_removal_loop_->Quit();
}
base::FilePath GetRefreshTokenToDeviceIdMapFilePath() const {
@@ -170,7 +171,7 @@ class DeviceIDTest : public OobeBaseTest,
json.c_str(), json.length()));
}
- base::RunLoop user_removal_loop_;
+ std::unique_ptr<base::RunLoop> user_removal_loop_;
};
// Add the first user and check that device ID is consistent.

Powered by Google App Engine
This is Rietveld 408576698