Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Unified Diff: chrome/browser/chromeos/login/screenshot_testing/screenshot_tester.h

Issue 2571473002: Fix cases where RunLoop is created without a MessageLoop. (Closed)
Patch Set: Fix chromeos tests. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/timer/timer_unittest.cc ('k') | chrome/browser/chromeos/login/screenshot_testing/screenshot_tester.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/login/screenshot_testing/screenshot_tester.h
diff --git a/chrome/browser/chromeos/login/screenshot_testing/screenshot_tester.h b/chrome/browser/chromeos/login/screenshot_testing/screenshot_tester.h
index 52f2d351d3a2ccd233cd3d2e0fc36be6383b7445..64741571f6500568bd7e3a5806fb4f9371bd9d1c 100644
--- a/chrome/browser/chromeos/login/screenshot_testing/screenshot_tester.h
+++ b/chrome/browser/chromeos/login/screenshot_testing/screenshot_tester.h
@@ -8,11 +8,11 @@
#include <string>
#include <vector>
+#include "base/callback.h"
#include "base/files/file_path.h"
#include "base/macros.h"
#include "base/memory/ref_counted_memory.h"
#include "base/memory/weak_ptr.h"
-#include "base/run_loop.h"
#include "third_party/skia/include/core/SkBitmap.h"
namespace chromeos {
@@ -137,9 +137,8 @@ class ScreenshotTester {
// and difference between them and golden ones will be stored.
base::FilePath artifacts_dir_;
- // |run_loop_| and |run_loop_quitter_| are used to synchronize
- // with ui::GrabWindowSnapshotAsync.
- base::RunLoop run_loop_;
+ // |run_loop_quitter_| is used to stop waiting when
+ // ui::GrabWindowSnapshotAsync completes.
base::Closure run_loop_quitter_;
// Is true when we're in test mode:
« no previous file with comments | « base/timer/timer_unittest.cc ('k') | chrome/browser/chromeos/login/screenshot_testing/screenshot_tester.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698