Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 2571393002: VM: [Kernel] don't crash when encountering generic methods in Kernel. (Closed)

Created:
4 years ago by Vyacheslav Egorov (Google)
Modified:
4 years ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org, Lasse Reichstein Nielsen
Target Ref:
refs/heads/master
Visibility:
Public.

Description

VM: [Kernel] Do not crash when encountering generic methods in Kernel. Instead do what source based front-end does for now: replace type parameters with dynamic. BUG= R=kmillikin@google.com Committed: https://github.com/dart-lang/sdk/commit/b0a0a429627d792ee934ed1e6f141e86814438e2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -28 lines) Patch
M runtime/vm/kernel_to_il.h View 2 chunks +22 lines, -1 line 0 comments Download
M runtime/vm/kernel_to_il.cc View 6 chunks +49 lines, -19 lines 0 comments Download
M tests/language/language_kernel.status View 2 chunks +3 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Vyacheslav Egorov (Google)
PTAL
4 years ago (2016-12-14 21:41:10 UTC) #2
Vyacheslav Egorov (Google)
PTAL
4 years ago (2016-12-15 12:17:46 UTC) #5
Kevin Millikin (Google)
LGTM.
4 years ago (2016-12-15 12:31:34 UTC) #6
Vyacheslav Egorov (Google)
4 years ago (2016-12-15 15:23:46 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b0a0a429627d792ee934ed1e6f141e86814438e2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698