Issue 2571373002: Workaround for accessing part sources while resolving a library.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2571373002: Workaround for accessing part sources while resolving a library. (Closed)

Created:
4 years ago by scheglov

Modified:
4 years ago

Reviewers:
Paul Berry, Brian Wilkerson

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 4 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -0 lines)			Patch
	M	pkg/analyzer/lib/src/dart/analysis/driver.dart	View		1 chunk	+10 lines, -0 lines	0 comments	Download
	M	pkg/analyzer/test/src/dart/analysis/driver_test.dart	View		1 chunk	+19 lines, -0 lines	0 comments	Download

Total messages: 5 (1 generated)

scheglov

Committed patchset #1 (id:1) manually as 3fe9a331c8781097d81733a9438afc7e74385ffc (presubmit successful).

4 years ago (2016-12-14 22:08:31 UTC) #4

Paul Berry

4 years ago (2016-12-14 22:46:26 UTC) #5

Message was sent while issue was closed.

lgtm, although personally I'm not convinced that bug 28110 is worth fixing--see
my comments on the bug report.