Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(673)

Unified Diff: pkg/analysis_server/test/context_manager_test.dart

Issue 2571353002: Fix updating source factory in driver (issue 28086) (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analysis_server/lib/src/context_manager.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/test/context_manager_test.dart
diff --git a/pkg/analysis_server/test/context_manager_test.dart b/pkg/analysis_server/test/context_manager_test.dart
index 2552579ef2658149f39bccfe100f87cbb6c8dc5d..db3bf030854064f63085cb6b6e6ebfe1135f4cd0 100644
--- a/pkg/analysis_server/test/context_manager_test.dart
+++ b/pkg/analysis_server/test/context_manager_test.dart
@@ -1742,47 +1742,6 @@ class AbstractContextManagerTest_Driver extends AbstractContextManagerTest {
// test/context_manager_test.dart 154:13 AbstractContextManagerTest.test_embedder_packagespec.<async>
return super.test_embedder_packagespec();
}
-
- @failingTest
- void test_setRoots_addPackageRoot() {
- // Bad state: Should not be used with the new analysis driver
- // package:analysis_server/src/context_manager.dart 561:7 ContextManagerImpl.folderMap
- // package:analysis_server/src/context_manager.dart 1709:31 ContextManagerImpl._updateContextPackageUriResolver
- // package:analysis_server/src/context_manager.dart 1668:5 ContextManagerImpl._recomputeFolderDisposition
- // package:analysis_server/src/context_manager.dart 1420:7 ContextManagerImpl._handleWatchEvent
- return super.test_setRoots_addPackageRoot();
- }
-
- @failingTest
- void test_setRoots_changePackageRoot() {
- // Bad state: Should not be used with the new analysis driver
- // package:analysis_server/src/context_manager.dart 561:7 ContextManagerImpl.folderMap
- // package:analysis_server/src/context_manager.dart 1709:31 ContextManagerImpl._updateContextPackageUriResolver
- // package:analysis_server/src/context_manager.dart 1668:5 ContextManagerImpl._recomputeFolderDisposition
- // package:analysis_server/src/context_manager.dart 1420:7 ContextManagerImpl._handleWatchEvent
- return super.test_setRoots_changePackageRoot();
- }
-
- @failingTest
- void test_setRoots_removePackageRoot() {
- // Bad state: Should not be used with the new analysis driver
- // package:analysis_server/src/context_manager.dart 561:7 ContextManagerImpl.folderMap
- // package:analysis_server/src/context_manager.dart 1709:31 ContextManagerImpl._updateContextPackageUriResolver
- // package:analysis_server/src/context_manager.dart 1668:5 ContextManagerImpl._recomputeFolderDisposition
- // package:analysis_server/src/context_manager.dart 1420:7 ContextManagerImpl._handleWatchEvent
- return super.test_setRoots_removePackageRoot();
- }
-
- @failingTest
- test_watch_modifyPackageMapDependency_fail() async {
- // Bad state: Should not be used with the new analysis driver
- // package:analysis_server/src/context_manager.dart 561:7 ContextManagerImpl.folderMap
- // package:analysis_server/src/context_manager.dart 1709:31 ContextManagerImpl._updateContextPackageUriResolver
- // package:analysis_server/src/context_manager.dart 1668:5 ContextManagerImpl._recomputeFolderDisposition
- // package:analysis_server/src/context_manager.dart 1420:7 ContextManagerImpl._handleWatchEvent
- //return super.test_watch_modifyPackageMapDependency_fail();
- fail('StateError thrown');
- }
}
abstract class ContextManagerTest {
« no previous file with comments | « pkg/analysis_server/lib/src/context_manager.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698