Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 2571353002: Fix updating source factory in driver (issue 28086) (Closed)

Created:
4 years ago by Brian Wilkerson
Modified:
4 years ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -56 lines) Patch
M pkg/analysis_server/lib/src/context_manager.dart View 4 chunks +23 lines, -15 lines 0 comments Download
M pkg/analysis_server/test/context_manager_test.dart View 1 chunk +0 lines, -41 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
4 years ago (2016-12-14 20:59:36 UTC) #2
scheglov
LGTM
4 years ago (2016-12-14 21:00:38 UTC) #3
Brian Wilkerson
4 years ago (2016-12-14 21:08:28 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a8e9a1f1085c377099b0808a0e61e269b7f9092f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698