Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(794)

Issue 2571333002: Fix completion tests that attempted to resolve a library. (Closed)

Created:
4 years ago by scheglov
Modified:
4 years ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix completion tests that attempted to resolve a library. We don't need this with the new analysis driver. The library element will be resynthesized on demand. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/8dbfef1cf1a3d651e061a224b3dbb4f9a1ec88bb

Patch Set 1 #

Messages

Total messages: 4 (1 generated)
scheglov
4 years ago (2016-12-14 20:27:28 UTC) #1
Brian Wilkerson
lgtm
4 years ago (2016-12-14 20:30:50 UTC) #2
scheglov
4 years ago (2016-12-14 20:33:12 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8dbfef1cf1a3d651e061a224b3dbb4f9a1ec88bb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698