Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1156)

Unified Diff: device/vr/vr_service_impl.h

Issue 2571323002: Fix leak in VRServiceImpl (Closed)
Patch Set: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « device/vr/vr_display_impl.cc ('k') | device/vr/vr_service_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: device/vr/vr_service_impl.h
diff --git a/device/vr/vr_service_impl.h b/device/vr/vr_service_impl.h
index cd83c49043ab38bf5d157b850110704e5de1b97c..ba8b6b162dd3949158b6676a41159a3ba858dc60 100644
--- a/device/vr/vr_service_impl.h
+++ b/device/vr/vr_service_impl.h
@@ -19,9 +19,10 @@ namespace device {
class VRServiceImpl : public mojom::VRService {
public:
+ DEVICE_VR_EXPORT VRServiceImpl();
DEVICE_VR_EXPORT ~VRServiceImpl() override;
- DEVICE_VR_EXPORT static void BindRequest(
+ DEVICE_VR_EXPORT static void Create(
mojo::InterfaceRequest<mojom::VRService> request);
mojom::VRServiceClient* client() { return client_.get(); }
@@ -41,24 +42,16 @@ class VRServiceImpl : public mojom::VRService {
friend class VRDisplayImplTest;
friend class VRServiceImplTest;
- DEVICE_VR_EXPORT VRServiceImpl();
-
- // Mojo connection handling.
- DEVICE_VR_EXPORT void Bind(mojo::InterfaceRequest<mojom::VRService> request);
- void RemoveFromDeviceManager();
void RemoveDevice(VRDevice* device);
void SetListeningForActivate(bool listening) override;
- using DisplayImplMap = std::map<VRDevice*, std::unique_ptr<VRDisplayImpl>>;
- DisplayImplMap displays_;
+ std::map<VRDevice*, std::unique_ptr<VRDisplayImpl>> displays_;
mojom::VRServiceClientPtr client_;
bool listening_for_activate_;
- std::unique_ptr<mojo::Binding<mojom::VRService>> binding_;
-
DISALLOW_COPY_AND_ASSIGN(VRServiceImpl);
};
« no previous file with comments | « device/vr/vr_display_impl.cc ('k') | device/vr/vr_service_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698