Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Unified Diff: device/vr/vr_service_impl.h

Issue 2571323002: Fix leak in VRServiceImpl (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: device/vr/vr_service_impl.h
diff --git a/device/vr/vr_service_impl.h b/device/vr/vr_service_impl.h
index cd83c49043ab38bf5d157b850110704e5de1b97c..11af76e263444521472ea3de2bc6e0aefcd148ca 100644
--- a/device/vr/vr_service_impl.h
+++ b/device/vr/vr_service_impl.h
@@ -19,9 +19,10 @@ namespace device {
class VRServiceImpl : public mojom::VRService {
public:
+ DEVICE_VR_EXPORT VRServiceImpl();
DEVICE_VR_EXPORT ~VRServiceImpl() override;
- DEVICE_VR_EXPORT static void BindRequest(
+ DEVICE_VR_EXPORT static void Create(
mojo::InterfaceRequest<mojom::VRService> request);
mojom::VRServiceClient* client() { return client_.get(); }
@@ -41,11 +42,6 @@ class VRServiceImpl : public mojom::VRService {
friend class VRDisplayImplTest;
friend class VRServiceImplTest;
- DEVICE_VR_EXPORT VRServiceImpl();
-
- // Mojo connection handling.
- DEVICE_VR_EXPORT void Bind(mojo::InterfaceRequest<mojom::VRService> request);
- void RemoveFromDeviceManager();
void RemoveDevice(VRDevice* device);
void SetListeningForActivate(bool listening) override;
@@ -57,8 +53,6 @@ class VRServiceImpl : public mojom::VRService {
bool listening_for_activate_;
- std::unique_ptr<mojo::Binding<mojom::VRService>> binding_;
-
DISALLOW_COPY_AND_ASSIGN(VRServiceImpl);
};

Powered by Google App Engine
This is Rietveld 408576698