Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Side by Side Diff: content/browser/frame_host/render_frame_host_impl.cc

Issue 2571323002: Fix leak in VRServiceImpl (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | device/vr/vr_service_impl.h » ('j') | device/vr/vr_service_impl.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/frame_host/render_frame_host_impl.h" 5 #include "content/browser/frame_host/render_frame_host_impl.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/command_line.h" 10 #include "base/command_line.h"
(...skipping 2246 matching lines...) Expand 10 before | Expand all | Expand 10 after
2257 // This is to support usage of WebSockets in cases in which there is an 2257 // This is to support usage of WebSockets in cases in which there is an
2258 // associated RenderFrame. This is important for showing the correct security 2258 // associated RenderFrame. This is important for showing the correct security
2259 // state of the page and also honoring user override of bad certificates. 2259 // state of the page and also honoring user override of bad certificates.
2260 GetInterfaceRegistry()->AddInterface( 2260 GetInterfaceRegistry()->AddInterface(
2261 base::Bind(&WebSocketManager::CreateWebSocket, 2261 base::Bind(&WebSocketManager::CreateWebSocket,
2262 process_->GetID(), 2262 process_->GetID(),
2263 routing_id_)); 2263 routing_id_));
2264 2264
2265 #if defined(ENABLE_WEBVR) 2265 #if defined(ENABLE_WEBVR)
2266 GetInterfaceRegistry()->AddInterface<device::mojom::VRService>( 2266 GetInterfaceRegistry()->AddInterface<device::mojom::VRService>(
2267 base::Bind(&device::VRServiceImpl::BindRequest)); 2267 base::Bind(&device::VRServiceImpl::Create));
2268 #endif 2268 #endif
2269 if (base::FeatureList::IsEnabled(features::kGenericSensor)) { 2269 if (base::FeatureList::IsEnabled(features::kGenericSensor)) {
2270 GetInterfaceRegistry()->AddInterface( 2270 GetInterfaceRegistry()->AddInterface(
2271 base::Bind(&device::SensorProviderImpl::Create, 2271 base::Bind(&device::SensorProviderImpl::Create,
2272 BrowserThread::GetTaskRunnerForThread(BrowserThread::FILE)), 2272 BrowserThread::GetTaskRunnerForThread(BrowserThread::FILE)),
2273 BrowserThread::GetTaskRunnerForThread(BrowserThread::IO)); 2273 BrowserThread::GetTaskRunnerForThread(BrowserThread::IO));
2274 } 2274 }
2275 2275
2276 #if BUILDFLAG(ENABLE_WEBRTC) 2276 #if BUILDFLAG(ENABLE_WEBRTC)
2277 // BrowserMainLoop::GetInstance() may be null on unit tests. 2277 // BrowserMainLoop::GetInstance() may be null on unit tests.
(...skipping 1049 matching lines...) Expand 10 before | Expand all | Expand 10 after
3327 // There is no pending NavigationEntry in these cases, so pass 0 as the 3327 // There is no pending NavigationEntry in these cases, so pass 0 as the
3328 // pending_nav_entry_id. If the previous handle was a prematurely aborted 3328 // pending_nav_entry_id. If the previous handle was a prematurely aborted
3329 // navigation loaded via LoadDataWithBaseURL, propagate the entry id. 3329 // navigation loaded via LoadDataWithBaseURL, propagate the entry id.
3330 return NavigationHandleImpl::Create( 3330 return NavigationHandleImpl::Create(
3331 params.url, frame_tree_node_, is_renderer_initiated, 3331 params.url, frame_tree_node_, is_renderer_initiated,
3332 params.was_within_same_page, base::TimeTicks::Now(), 3332 params.was_within_same_page, base::TimeTicks::Now(),
3333 entry_id_for_data_nav, false); // started_from_context_menu 3333 entry_id_for_data_nav, false); // started_from_context_menu
3334 } 3334 }
3335 3335
3336 } // namespace content 3336 } // namespace content
OLDNEW
« no previous file with comments | « no previous file | device/vr/vr_service_impl.h » ('j') | device/vr/vr_service_impl.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698